629100 - Fullscreen video stretches top and bottom rows of pixels to edge of screen

Status: RESOLVED FIXED

(Core :: Graphics, defect, P2)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We'd expect black areas above and below the video area, which is centered, but we see that the pixels from the edge of the video is stretched to the top (and bottom) of the screen.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Alex - any update here?

Comment 2

[Alex Pakhotin (:alexp)]

I'm on it!
Sorry for a delay - I was investigating a couple of crash bugs, and then had issues with my build, which was crashing every time while opening the page with the video.
Finally I have a usable build, and at least can see and debug the issue.

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Screenshot

Comment 4

[Alex Pakhotin (:alexp)]

This doesn't happen in Beta 3 - apparently something changed recently caused this issue.

Comment 5

[Alex Pakhotin (:alexp)]

Seems like the issue was introduced between the builds 20110125044444 and 20110126042414.
What related to video rendering did land around January 25-26?

Comment 6

[Wesley Johnston (:wesj)]

Bug 627273?

Comment 7

[Alex Pakhotin (:alexp)]

And the winner is...

The first bad revision is:
changeset:   61312:73bfa3627d0c
user:        Chris Jones <[e-mail]>
date:        Wed Jan 26 00:26:37 2011 -0600
summary:     Bug 627273, part 4: Basic impl of ImageLayer tiling for basic layers. r=roc,vlad

http://hg.mozilla.org/mozilla-central/rev/73bfa3627d0c

Guys, can you have a look at this change please. Something is wrong with those rectangles.

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Sorry, your bisect found a known-broken changeset.  Note the followups

657f6dac1e0c
2011-01-26 13:25 -0600	Chris Jones - Followup to bug 627273: Fix bad fix. r=Bas a=b

0e42a4b9e952
2011-01-26 16:12 -0600	Chris Jones - Fix for the fix for the fix of bug 627273. r=roc a=b

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

... but if 0e42a4b9e952 is still broken, then it's bug 627273.

Comment 10

[Alex Pakhotin (:alexp)]

Yes, I noticed there were fixes for the fixes in that bug, but just wanted to find the actual change, which started it.

The fact is that the issue with edge pixels spreading appeared with the change 61312:73bfa3627d0c, and 61347:0e42a4b9e952 did not fix it.
By the way, the first "fix for the fix" (61339:657f6dac1e0c) propagated this problem to the paused video as well, and 61347 fixed that. The static image of the paused video now looks fine, but the problem is still there when the video is playing.

Do you have any clues on why this spreading happens, and what I could try to fix it?
I'll have another look at the actual changes but just a simple method of trial-and-error is not very effective - need some hints from someone who knows the details of the fix.

Comment 11

[Alex Pakhotin (:alexp)]

Attachment: Fix

Fixed the same way as in the last patch in bug 627273, only for the BasicShadowImageLayer.
Graphics guys, can you please confirm if it's a correct approach.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/645fce13f10a