629116 - Normalize dialects in accept-language to lowercase per convention

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Although the RFC says accept-lang entries are supposed to be case-insensitive, convention appears to be that they should be all lowercase (Opera and Chrome do not; Firefox, Safari, OmniWeb do).  Sam has found at least one website that breaks (sends you your third-favorite language) if you use "en-US" instead of "en-us" (skips "en-US" because of caps and skips "en" just because). 

Once upon a time, before Apple switched the format of locales in AppleLanguages, we did this correctly (1.6.x on 10.3.9 gets it right); now we don't, and the fix for "servers skip 'en'" made it worse by hard-coding "en-US" as the override.

We should fix our code to adhere to convention and spare our users problems with more buggy sites.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Follow convention and lowercase languages

This makes sure an individual item is lowercased (for the 10.4+ hyphen-separated locale format) and also fixes the "if only 'en', add 'en-us'" override to be lowercased.

I checked on cb-x1 and it was using new-style "en-US" locales in AppleLanguages, which means all Intel Macs should have shipped using hyphens, and the underscore-to-hyphen conversion part of convertLocaleToHTTPLanguage: will only be needed as long as we support PPC Macs, which could have shipped with an OS that used underscores in AppleLanguages.  I added a note to that method's comment to that effect.

Comment 2

[Stuart Morgan]

Comment on attachment 507362 [details] [diff] [review]
Follow convention and lowercase languages

sr=smorgan.

Bets on how long until we hit a server that requires en-US instead of en-us? ;)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/5f91bf57294a

(In reply to comment #2)
> Bets on how long until we hit a server that requires en-US instead of en-us? ;)

I'm guessing Google has at least one misconfigured server out there somewhere ;)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

CAMINO_2_0_BRANCH in advance of 2.0.7.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

2.0.7 ended up being an emergency release.