629192 - mozRequestAnimationFrame callbacks fire while a modal dialog is open

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[James Robinson]

User-Agent:       Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre
Build Identifier: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre

mozRequestAnimationFrame callbacks will fire while a modal dialog (such as window.alert() is up, which violates javascript's general aversion to reentrancy.  For example:

var startTime = Date.now();
window.mozRequestAnimationFrame(function(){window.endTime=Date.now();});
window.alert("hi");

if the user takes 2 seconds to dismiss the dialog, endTime-startTime should be >= 2000.  Instead it's much shorter.

Reproducible: Always

Steps to Reproduce:
see script 



The experimental WebKit implementation of requestAnimationFrame defers invoking the callback until the dialog is dismissed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm.  I suppose we could do that, though of course declarative animations _do_ continue while the modal dialog is up...

Olli, is just checking EventHandlingSuppressed() on the document involved the right thing to do?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I'd check top windows modal state depth.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Talked to smaug.  Sounds like we need to do both, actually.

We need to add a sane accessor for IsInModalState().

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

James, does webkit fire animation callbacks while there is a sync XHR being processed?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Apparently it does not.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixeed by bug 675121.