Don't clobber all packages in mobile build.mk's package target

RESOLVED FIXED

Status

Fennec Graveyard
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jhford, Assigned: jhford)

Tracking

Trunk
x86_64
Linux

Details

Attachments

(2 attachments)

Created attachment 507268 [details] [diff] [review]
stop clobbering all packages in package target for mobile

the package target in the mobile-browser version of build.mk silently deletes all fennec-* files in obdir/dist.  This line was added in for http://hg.mozilla.org/mobile-browser/rev/0b21caeb656c which seems to be before the switch from xulrunner to non-xulrunner builds.

This patch removes this line entirely and makes the mobile-browser's build.mk package target very similar to the mozilla-central/browser/build.mk target.

If we do not remove this line, can we at least change from @rm to rm to make this more visible in build logs?

I have tested this patch locally and can submit a build to try if desired.
Attachment #507268 - Flags: review?(mark.finkle)
Assignee: nobody → jhford
Comment on attachment 507268 [details] [diff] [review]
stop clobbering all packages in package target for mobile

John - a Try run might be a good idea, just in case something strange happens.
Attachment #507268 - Flags: review?(mark.finkle) → review+
(In reply to comment #1)
> Comment on attachment 507268 [details] [diff] [review]
> stop clobbering all packages in package target for mobile
> 
> John - a Try run might be a good idea, just in case something strange happens.

Ok, I will do that now.
Comment on attachment 507268 [details] [diff] [review]
stop clobbering all packages in package target for mobile

(In reply to comment #2)
> (In reply to comment #1)
> > John - a Try run might be a good idea, just in case something strange happens.
> 
> Ok, I will do that now.

Try build done http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/jford@mozilla.com-5ebf8276bb2c/

I don't have commit on mobile-browser, how do I go about landing this for mobile-browser?
(In reply to comment #3)

> I don't have commit on mobile-browser, how do I go about landing this for
> mobile-browser?

I can land it
pushed:
http://hg.mozilla.org/mobile-browser/rev/c37b6862d388
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 6

6 years ago
Is this fixed? Should it be marked as verified fixed?
it has been reverted to previous behaviour.  I don't have any intention of doing anything more on this at this point as my need for it is gone and I think I was the only one who was pushing for it.
Resolution: FIXED → INCOMPLETE

Updated

6 years ago
Status: RESOLVED → VERIFIED
Blocks: 557260
Status: VERIFIED → REOPENED
Resolution: INCOMPLETE → ---
Does anyone remember what the issue was here the last time we tried this?

Updated

6 years ago
tracking-firefox5: --- → ?

Updated

6 years ago
tracking-firefox6: --- → ?

Updated

6 years ago
tracking-firefox5: ? → +
Comment on attachment 507268 [details] [diff] [review]
stop clobbering all packages in package target for mobile

Mark,  I am re-requesting review on this patch because it has been a long time since you originally gave it r+ and I want to make sure that you are still ok with it.

The reason that I want to land this patch again is that it allows us to be a lot more flexible with our automation and we have addressed the issues that caused us to backout last time.  Currently, we have to run make package as the very first step, because it clobbers the product of package-tests, buildsymbols and deb.

Bug 557260 is tracking the work to fully integrate mobile builds into desktop build infrastructure.  This allows us to reuse code for desktop and mobile which enables the entire releng team to work on mobile builds and paves the way to an integrated release process.

In preperation for this landing, we have started doing the required rm -rf dist/fennec* in our automation right before the make package call.  The reason we had to back out the last time we tried to land, is that we didn't have the replacement deletion in automation.

I am not sure how the flags work and the state of each tree, but I would need to land this patch on mozilla-aurora, mozilla-beta and mozilla-central.  This patch has been tested, is not part of shipping product code and has a simple backout strategy.

I don't have level-3 commit, so I will need someone to do the actual push to the three repositories and will upload a mercurial changeset for landing if this is r+.
Attachment #507268 - Flags: review+ → review?(mark.finkle)
Comment on attachment 507268 [details] [diff] [review]
stop clobbering all packages in package target for mobile

let's land on m-c first and see how things go. We can ask for approval for the other repos after that.
Attachment #507268 - Flags: review?(mark.finkle) → review+
(In reply to comment #10)
> Comment on attachment 507268 [details] [diff] [review] [review]
> stop clobbering all packages in package target for mobile
> 
> let's land on m-c first and see how things go. We can ask for approval for
> the other repos after that.

Cool, I'll upload the changeset now then.
Created attachment 534783 [details] [diff] [review]
mercurial changeset

Mercurial changeset to push to mozilla-central
Comment on attachment 534783 [details] [diff] [review]
mercurial changeset

carrying r+ forward
Attachment #534783 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/07cf571af750
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → FIXED

Updated

6 years ago
tracking-firefox6: ? → +
(In reply to comment #10)
> Comment on attachment 507268 [details] [diff] [review] [review]
> stop clobbering all packages in package target for mobile
> 
> let's land on m-c first and see how things go. We can ask for approval for
> the other repos after that.

I've already nom'd this bug, and got it approved for landing on mozilla-{aurora,beta} - see the new "tracking-firefox5" and "tracking-firefox6" flags. 

Feel free to land in mozilla-{aurora,beta} whenever you are ready.
(In reply to comment #15)
> Feel free to land in mozilla-{aurora,beta} whenever you are ready.

I don't have level 3 commit, so someone else will need to land this patch in -beta and -aurora
http://hg.mozilla.org/mozilla-aurora/rev/ef4731aefc12
status-firefox6: --- → fixed
http://hg.mozilla.org/releases/mozilla-beta/rev/42357cbbb379
status-firefox5: --- → fixed
You need to log in before you can comment on or make changes to this bug.