629230 - mochitests-2: test_bug511449.html should not execute SimpleTest.finish() from a callback

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Serge Gautherie (:sgautherie)]

(Noticed while investigating bug 556687.)

I am pretty sure this is causing no harm atm but it would be preferable to be safe(r).

NB: This would be fixed by bug 615546, if it was allowed to stay in the tree
:-<

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Wrap the call in SimpleTest.executeSoon() (ftb)

Comment 2

[Dão Gottwald [:dao]]

Why should SimpleTest.finish not be executed from a callback?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Why should SimpleTest.finish not be executed from a callback?

In case some other part of the test (still) runs after the callback returns.
It's not the case with this test atm, but could be if it ever gets modified.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 507301 [details] [diff] [review]
(Av1) Wrap the call in SimpleTest.executeSoon() (ftb)

I don't think you need to pre-emptively protect against that - it's pretty obvious that tests should only call finish() once they are actually finished. Even if you did need to protect against that, this doesn't really do it, since adding an additional delay still does not guarantee that finish() is called last.