Closed Bug 629230 Opened 12 years ago Closed 12 years ago

mochitests-2: test_bug511449.html should not execute SimpleTest.finish() from a callback

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
minor

Tracking

()

RESOLVED INVALID
mozilla2.0b11

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

(Noticed while investigating bug 556687.)

I am pretty sure this is causing no harm atm but it would be preferable to be safe(r).

NB: This would be fixed by bug 615546, if it was allowed to stay in the tree
:-<
Depends on: 615546
Blocks: 380960
Why should SimpleTest.finish not be executed from a callback?
(In reply to comment #2)
> Why should SimpleTest.finish not be executed from a callback?

In case some other part of the test (still) runs after the callback returns.
It's not the case with this test atm, but could be if it ever gets modified.
Comment on attachment 507301 [details] [diff] [review]
(Av1) Wrap the call in SimpleTest.executeSoon() (ftb)

I don't think you need to pre-emptively protect against that - it's pretty obvious that tests should only call finish() once they are actually finished. Even if you did need to protect against that, this doesn't really do it, since adding an additional delay still does not guarantee that finish() is called last.
Attachment #507301 - Flags: review?(gavin.sharp) → review-
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.