629242 - js/jsd/jsdebug.c:584:5: warning: implicit declaration of function 'jsd_EnableSingleStepInterrupts'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this build warning
> js/jsd/jsdebug.c: In function 'JSD_EnableSingleStepInterrupts':
> js/jsd/jsdebug.c:584:5: warning: implicit declaration of function 'jsd_EnableSingleStepInterrupts'

Flagged code:
> 579 JSD_PUBLIC_API(JSBool)
> 580 JSD_EnableSingleStepInterrupts(JSDContext* jsdc, JSDScript* jsdscript, JSBool enable)
> 581 {
> 582     JSD_ASSERT_VALID_CONTEXT(jsdc);
> 583     JSD_ASSERT_VALID_SCRIPT(jsdscript);
> 584     return jsd_EnableSingleStepInterrupts(jsdc, jsdscript, enable);
> 585 }

From a quick MXR search[1], it looks like the undeclared function lives in jsd_scpt.c:
> 594 JSBool
> 595 jsd_EnableSingleStepInterrupts(JSDContext* jsdc, JSDScript* jsdscript, JSBool enable)
> 596 {
http://mxr.mozilla.org/mozilla-central/source/js/jsd/jsd_scpt.c#595

This function probably wants to be declared in jsd.h.

[1] http://mxr.mozilla.org/mozilla-central/search?string=jsd_EnableSingleStepInterrupts&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Declare function in header, check errors

Declare it, and also propagate error returns. Guess I should get a rubber stamp for the latter.

Comment 2

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/tracemonkey/rev/e8c7fea4eff3

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/e8c7fea4eff3