629394 - add hypertext downcasting

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch1v1: turn children flags into generic flags

Comment 1

[alexander :surkov (:asurkov)]

Attachment: part2v1: add AsHyperText method

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Alexander I haven't look yet, but what is your risk assessment for these patches? We're really tightening up now.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch3v1: replace do_QueryObject on AsHyperText

I didn't changed MSAA part (CAccessible) because these classes aren't nsAccessible. Saving this for the future.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> Alexander I haven't look yet, but what is your risk assessment for these
> patches? We're really tightening up now.

I bet you will before a+ :) No risk. I just need a quick way to downcast accessibles for the future work where it may be a bottleneck (lot of simple operations).

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #4)
> (In reply to comment #2)
> > Alexander I haven't look yet

> I bet you will before a+

You can count on it :)

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #4)
> I just need a quick way to downcast
> accessibles for the future work

Blocker work?

Comment 7

[[e-mail]]

Comment on attachment 507487 [details] [diff] [review]
part2v1: add AsHyperText method

>+  /**
>+   * Flags describing the accessible itself.
>+   */
>+  enum AccessibleTypes {
>+    eHyperTextAccessible = 1 << 2
Is this near enough the children flag that makes it obvious why it starts at 2?

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> (In reply to comment #4)
> > I just need a quick way to downcast
> > accessibles for the future work
> 
> Blocker work?

for deeply related softblocker, that trimmed offset crash, for short relation not blocker - cache rendered text on a11y side. Nowdays I don't know what is blocker for a11y, I just work on a fix for bug 625653.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to comment #7)

> >+  enum AccessibleTypes {
> >+    eHyperTextAccessible = 1 << 2
> Is this near enough the children flag that makes it obvious why it starts at 2?

I'll add a comment these flags should be in sync with ChildrenFlags. Thanks!

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 507489 [details] [diff] [review]
patch3v1: replace do_QueryObject on AsHyperText

Did do_QueryObject offer more protection than checking 'mFlags & eHyperTextAccessible' provides?

Comment 11

[alexander :surkov (:asurkov)]

(In reply to comment #10)

> Did do_QueryObject offer more protection than checking 'mFlags &
> eHyperTextAccessible' provides?

in what means, sorry?

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #11)
> (In reply to comment #10)
> 
> > Did do_QueryObject offer more protection than checking 'mFlags &
> > eHyperTextAccessible' provides?
> 
> in what means, sorry?

Actually I think my answer is no :) (no worries)

Comment 13

[alexander :surkov (:asurkov)]

patch1v1: turn children flags into generic flags - http://hg.mozilla.org/mozilla-central/rev/307d7ab0729f

part2v1: add AsHyperText method - http://hg.mozilla.org/mozilla-central/rev/523d042cda97

patch3v1: replace do_QueryObject on AsHyperText - http://hg.mozilla.org/mozilla-central/rev/c85650001fa9

landed on 2.0 beta11