629432 - [Nexus S] Opening planet.mozilla.org frequently hangs the phone

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: logcat from phone hang (filtered for Gecko)

STEPS TO REPRODUCE:
 1. Visit planet.mozilla.org, and wait for it to load.

In the Fennec b4 candidate builds, this completely hangs my phone.  (Have tried twice today, and it's happened both times.)

This surprises me a bit, because over the last week, I've loaded planet a few times in Fennec nightlies, and there I tended to hit bug 627812.  But now, either because of something new in beta4 or because of something new on planet.mozilla.org, my phone is completely hanging instead. :-/

This is basically a spin-off of bug 624652, but I'm filing it as a new bug since patches have already landed for bug 624652.

Comment 1

[Tony Chung [:tchung]]

The same reproduces for me on step 1.   This is against Fennec 4 beta 4.

Mozilla/5.0 (Android; Linux armv71; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre Fennec/4.0b4

Comment 2

[Doug Turner (:dougt)]

my g2 runs out of memory right now on p.m.o.  while loading the page, i see all of the background applications die.  then I see a long pause where the UI is froze (around 30s), then I get an android dialog that allows me to "Force Quit".

Comment 3

[Tony Chung [:tchung]]

personally, i've never seen a "Force Quit" option on my Nexus S, so i would actually rejoice if i had that choice!

Comment 4

[Tony Chung [:tchung]]

Attachment: my log

Comment 5

[Tony Chung [:tchung]]

i cant use this device for more than an hour as a user without crashing or hanging.  adding relnote for beta 4, but we really need to fix this experience for beta 5.

Can anyone else with a Nexus S (besides me and daniel) comment on steps to reproduce and attach your logs?

Comment 6

[Doug Turner (:dougt)]

working on a fix...

Comment 7

[Doug Turner (:dougt)]

Attachment: patch v.1

uses /proc/meminfo instead of dalvik.
some cleanup.
note, this runs on all android devices now, not just the Nexus S.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 508074 [details] [diff] [review]
patch v.1

>+    nsRefPtr<nsMemoryWatcher> mMemoryWatcher;
shouldn't you use an nsCOMPtr here?

>+  : mLowWaterMark(5000)
>+  , mHighWaterMark(10000)
Where did you get these numbers? Can you add a comment explaining them?

>+  //  __android_log_print(ANDROID_LOG_INFO, "Gecko",
>+  //                      "CheckMemoryUsage: memFree %ld",
>+  //                      memFree);
remove this

>+++ b/widget/src/android/nsWindow.h
>+    void CheckMemoryUsage();

this doesn't seem to be used or defined

Comment 9

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/af70cc3963ac

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #8)
> Comment on attachment 508074 [details] [diff] [review]
> patch v.1
> 
> >+    nsRefPtr<nsMemoryWatcher> mMemoryWatcher;
> shouldn't you use an nsCOMPtr here?

No. COMPtrs are only to be used with interfaces.

Comment 11

[Doug Turner (:dougt)]

Attachment: followup

Comment 12

[Doug Turner (:dougt)]

this was backed out without reopening... I relanded w/ a fix:

http://hg.mozilla.org/mozilla-central/rev/f05874a6bac5
and
http://hg.mozilla.org/mozilla-central/rev/37e4ab3abc44

Comment 13

[Tony Chung [:tchung]]

I am still experiencing device lockup on planet.mozilla.org on the 2/14 build.  STR is basically comment 1.  

Anything i can do to verify this?  else, i'll reopen.

Comment 14

[Doug Turner (:dougt)]

nothing to do here.  most likely a nexus s*** bug.

Comment 15

[Daniel Holbert [:dholbert]]

(In reply to comment #13)
> I am still experiencing device lockup on planet.mozilla.org on the 2/14 build. 

same here, FWIW.  :(

Comment 16

[Daniel Holbert [:dholbert]]

I just updated to Android 2.3.3 (from 2.3.2) manually*, and I haven't been able to hang my phone since!  I opened 2 tabs of Planet Mozilla, 1 tab of Planet Ubuntu, and a tab for each front-page story on http://m.digg.com , and the phone has remained very responsive the whole time.

It looks like we zombify tabs (as I think we expect to) when memory usage gets too high -- so when I switch back to them, they reload the page from scratch.  And I haven't been able to make anything worse than that happen since updating.

(I'm using the latest fennec nightly, btw.)

WOOHOO!

tchung, can you confirm?

*following directions at http://phandroid.com/2011/02/24/manually-update-your-nexus-one-to-android-2-3-3-gingerbread/

Comment 17

[Tony Chung [:tchung]]

indeed.  updated nexus s to 2.3.3 today and havent hung on planet+7 open tabs since.  panning through planet has been very responsive so far.  commenting in here using fennec 2/23 nightly.  will continue to dogfood.