Closed
Bug 629462
Opened 11 years ago
Closed 11 years ago
Add a MailServices module
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a3
People
(Reporter: rain1, Assigned: rain1)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
|
9.52 KB,
patch
|
Bienvenu
:
review+
standard8
:
superreview+
|
Details | Diff | Splinter Review |
Toolkit has a Services module, and it would be nice to have a separate module for mailnews-specific services.
| Assignee | ||
Comment 1•11 years ago
|
||
The module will be available in all mail windows. I haven't switched any users over, though.
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #507595 -
Flags: superreview?(bugzilla)
Attachment #507595 -
Flags: review?(bienvenu)
Abbreviation are OK .. as with (MailServices, "ab","@mozilla.org/abmanager;1","nsIAbManager"); (everyone will expect addressbook here), but (MailServices, "mfn","@mozilla.org/messenger/msgnotificationservice;1", "nsIMsgFolderNotificationService"); "mfn" seems not that good, how about "foldernotify" ?
| Assignee | ||
Comment 3•11 years ago
|
||
(In reply to comment #2) > "mfn" seems not that good, > how about "foldernotify" > ? Yep, I'm worried about that too, but "foldernotify" doesn't seem to capture the fact that the service can be used for both messages and folders. Unless someone suggests something better, I'll probably go with something like mfnotification.
Comment 4•11 years ago
|
||
Comment on attachment 507595 [details] [diff] [review] patch, v1 These generally look fine to me. I think mfn is probably as reasonable as anything else.
Attachment #507595 -
Flags: superreview?(bugzilla) → superreview+
Updated•11 years ago
|
Attachment #507595 -
Flags: review?(bienvenu) → review+
| Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b278f56d68d2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
Updated•11 years ago
|
Version: unspecified → Trunk
| Assignee | ||
Comment 6•11 years ago
|
||
Can we have a dev doc for this? Something similar to <https://developer.mozilla.org/en/JavaScript_code_modules/Services.jsm> would be great.
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•