Closed Bug 629644 Opened 14 years ago Closed 14 years ago

Extra false positive failure in l10n tests due to non ASCII string used in querySelector

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-l10n])

Attachments

(1 file, 1 obsolete file)

Patch v1.1
2.36 KB, patch
adriank
: review+
Details | Diff | Splinter Review
We have a strange failure which needs investigation. For all locales it looks like we have an extra entry in the failures list of at least the accesskey test. Results: http://mozmill-archive.brasstacks.mozilla.com/#/l10n/reports Locale with some failures: http://mozmill-archive.brasstacks.mozilla.com/#/l10n/report/411e357fb507b6cd9cb9d168fe06e7ce Locale with only that stray failure: http://mozmill-archive.brasstacks.mozilla.com/#/l10n/report/411e357fb507b6cd9cb9d168fe05fa41
Attached patch Patch v1 (obsolete) — — Splinter Review
We should never never use access keys to reference elements we have to retrieve via querySelector.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #510551 - Flags: review?(aaron.train)
Summary: Extra false positive failure in each l10n test-run even if everything is ok → Extra false positive failure in l10n tests due to non ASCII string used in querySelector
Raising up severity to critical because we early abort the testrun for some locales with a non-ascii charset.
Severity: normal → critical
Attached patch Patch v1.1 — — Splinter Review
Updated patch with removed debug statement in dom-utils.
Attachment #510551 - Attachment is obsolete: true
Attachment #510552 - Flags: review?(aaron.train)
Attachment #510551 - Flags: review?(aaron.train)
Comment on attachment 510552 [details] [diff] [review] Patch v1.1 looks ok for me. Review done based on IRC discussion.
Attachment #510552 - Flags: review?(aaron.train) → review+
Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/ae23a535cdf5 (default) http://hg.mozilla.org/qa/mozmill-tests/rev/c94d73c583d8 (1.9.2)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: