Cache the XPConnect services for accesses from Places

RESOLVED FIXED in mozilla2.0b12

Status

()

Toolkit
Places
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla2.0b12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.84 KB, patch
Benjamin Smedberg
: review+
sdwilsh
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Followup to 629577.  sdwilsh said that he doesn't like us not caching the XPConnect service there, so here's a patch which does it through mozilla::services.
(Assignee)

Comment 1

7 years ago
Created attachment 507884 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #507884 - Flags: review?(benjamin)

Comment 2

7 years ago
What about the other call sites? (I guess dom/ should use nsContentUtils.)
In the Places code, don't bother checking the result.  I don't see how it would be possible for us to hit those code paths without having XPConnect around.
(Assignee)

Comment 4

7 years ago
(In reply to comment #2)
> What about the other call sites? (I guess dom/ should use nsContentUtils.)

They can be dealt with in their own bugs, I guess.
(Assignee)

Comment 5

7 years ago
Created attachment 507927 [details] [diff] [review]
Patch (v2)

(In reply to comment #3)
> In the Places code, don't bother checking the result.  I don't see how it would
> be possible for us to hit those code paths without having XPConnect around.

Done.
Attachment #507884 - Attachment is obsolete: true
Attachment #507927 - Flags: review?(benjamin)
Attachment #507884 - Flags: review?(benjamin)

Updated

7 years ago
Attachment #507927 - Flags: review?(benjamin) → review+
(Assignee)

Updated

7 years ago
Attachment #507927 - Flags: approval2.0?
Comment on attachment 507927 [details] [diff] [review]
Patch (v2)

a+ would take again
Attachment #507927 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Whiteboard: [needs landing]
(Assignee)

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/dfe5ab77a706
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.