Closed Bug 629697 Opened 9 years ago Closed 9 years ago

Cache the XPConnect services for accesses from Places

Categories

(Toolkit :: Places, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file, 1 obsolete file)

Followup to 629577.  sdwilsh said that he doesn't like us not caching the XPConnect service there, so here's a patch which does it through mozilla::services.
Attached patch Patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #507884 - Flags: review?(benjamin)
What about the other call sites? (I guess dom/ should use nsContentUtils.)
In the Places code, don't bother checking the result.  I don't see how it would be possible for us to hit those code paths without having XPConnect around.
(In reply to comment #2)
> What about the other call sites? (I guess dom/ should use nsContentUtils.)

They can be dealt with in their own bugs, I guess.
Attached patch Patch (v2)Splinter Review
(In reply to comment #3)
> In the Places code, don't bother checking the result.  I don't see how it would
> be possible for us to hit those code paths without having XPConnect around.

Done.
Attachment #507884 - Attachment is obsolete: true
Attachment #507927 - Flags: review?(benjamin)
Attachment #507884 - Flags: review?(benjamin)
Attachment #507927 - Flags: review?(benjamin) → review+
Attachment #507927 - Flags: approval2.0?
Comment on attachment 507927 [details] [diff] [review]
Patch (v2)

a+ would take again
Attachment #507927 - Flags: approval2.0? → approval2.0+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/dfe5ab77a706
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.