Closed
Bug 629697
Opened 13 years ago
Closed 13 years ago
Cache the XPConnect services for accesses from Places
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file, 1 obsolete file)
4.84 KB,
patch
|
benjamin
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
Followup to 629577. sdwilsh said that he doesn't like us not caching the XPConnect service there, so here's a patch which does it through mozilla::services.
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
What about the other call sites? (I guess dom/ should use nsContentUtils.)
Comment 3•13 years ago
|
||
In the Places code, don't bother checking the result. I don't see how it would be possible for us to hit those code paths without having XPConnect around.
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to comment #2) > What about the other call sites? (I guess dom/ should use nsContentUtils.) They can be dealt with in their own bugs, I guess.
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #3) > In the Places code, don't bother checking the result. I don't see how it would > be possible for us to hit those code paths without having XPConnect around. Done.
Attachment #507884 -
Attachment is obsolete: true
Attachment #507927 -
Flags: review?(benjamin)
Attachment #507884 -
Flags: review?(benjamin)
Updated•13 years ago
|
Attachment #507927 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #507927 -
Flags: approval2.0?
Comment 6•13 years ago
|
||
Comment on attachment 507927 [details] [diff] [review] Patch (v2) a+ would take again
Attachment #507927 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dfe5ab77a706
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•