629697 - Cache the XPConnect services for accesses from Places

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[(no longer active)]

Followup to 629577.  sdwilsh said that he doesn't like us not caching the XPConnect service there, so here's a patch which does it through mozilla::services.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[[e-mail]]

What about the other call sites? (I guess dom/ should use nsContentUtils.)

Comment 3

[Shawn Wilsher :sdwilsh]

In the Places code, don't bother checking the result.  I don't see how it would be possible for us to hit those code paths without having XPConnect around.

Comment 4

[(no longer active)]

(In reply to comment #2)
> What about the other call sites? (I guess dom/ should use nsContentUtils.)

They can be dealt with in their own bugs, I guess.

Comment 5

[(no longer active)]

Attachment: Patch (v2)

(In reply to comment #3)
> In the Places code, don't bother checking the result.  I don't see how it would
> be possible for us to hit those code paths without having XPConnect around.

Done.

Comment 6

[Shawn Wilsher :sdwilsh]

Comment on attachment 507927 [details] [diff] [review]
Patch (v2)

a+ would take again

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/dfe5ab77a706