629723 - Decompiling for blame erroneously prints "use strict" directives

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Bug 628112 comment 9 mentions that "use strict" directives are being generated inappropriately:

> TypeError: "use strict";tab is undefined
> 
> Yikes. Cc'ing jimb. This looks like a bug recently introduced (which I should
> have foreseen) where decompiling for blame wrongly inserts "use strict"; if the
> code being blamed is strict.

What are the details? How do we reproduce this?

Comment 1

[Brendan Eich [:brendan]]

It's trivial:

js> function f(foo){"use strict";foo.bar}
js> f()
typein:6: TypeError: "use strict";foo is undefined

/be

Comment 2

[Jim Blandy :jimb]

Attachment: Don't include directive prologues when decompiling specific expressions for error messages.

This also sorts the test list in js/src/tests/ecma_5/extensions; the only
addition to the list is the regression test for this bug.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 509037 [details] [diff] [review]
Don't include directive prologues when decompiling specific expressions for error messages.

Cool. This should ride along into b12.

/be

Comment 4

[Brendan Eich [:brendan]]

Rob, can you approve the patch? Thanks,

/be

Comment 5

[Jim Blandy :jimb]

http://hg.mozilla.org/tracemonkey/rev/5f7eb378dac6

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/5f7eb378dac6