629743 - Test environment setup should install a fixed version of Mozmill

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Crowd Extension, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Right now the test environments setup script installs the most recent version of Mozmill available on pypi. We have to change that and only allow new versions of Mozmill once we have signed off and everything works as expected.

That requires a small change in the setup.py script. Aaron, would you like to do that?

Comment 1

[Aaron Train [:aaronmt]]

Not sure what setup.py script you're referring to. As far as I know I think Clint would have to expose the older versions of Mozmill for download on PyPi

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Sorry, I mean our setup.sh and setup.cmd scripts in the test environment.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - mozmill==1.5.1

I think this is what you want

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 508400 [details] [diff] [review]
Patch v1 - mozmill==1.5.1

>-easy_install -U mercurial mozrunner jsbridge mozmill
>+easy_install -U mercurial mozrunner jsbridge mozmill==1.5.1

Not sure if this will really work. Specifying the version only for mozmill could break the other modules. We should better remove dependencies and let easy_install decide which packages have to be installed. We have a hard-coded version dependency, so that should work. Please thoroughly test it with different versions.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Aaron, whats the reason for un-assigning yourself? I definitely need you help for 0.2.

Comment 6

[Aaron Train [:aaronmt]]

http://packages.python.org/distribute/easy_install.html#upgrading-a-package

Aside from maybe needing to specify quotes around the package and version I think that should work.

Specifying mozmill==1.5.1, installs its dependencies: MozRunner 2.5.2, and JSBridge 2.4.1, so I don't think its necessary in specifying the other modules. 

I think easy_install "mozmill==1.5.1" should be fine

Unassigned because aside from just playing with the package version, I don't have any any other knowledge about pip or easy_install. Happy to test this out though

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

(In reply to comment #6)
> Unassigned because aside from just playing with the package version, I don't
> have any any other knowledge about pip or easy_install. Happy to test this out
> though

It's not a matter of having no knowledge. For all the new stuff we are working on we have mostly no knowledge and have to find a way to get goals accomplished. I really would like to see you working on this bug.

Comment 8

[Aaron Train [:aaronmt]]

Attachment: install.log

Attached is my install log when I specify: easy_install -U mozmill==1.5.1

Comment 9

[Aaron Train [:aaronmt]]

Since easy_install is able to satisfy the dependencies on its own, we just have to change the lines in the environment setup files from [1] to [2]

[1] easy_install -U mercurial mozrunner jsbridge mozmill
[2] easy_install -U mercurial mozmill=1.5.1

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Have you tried to jump between releases and the latest release candidates? Does that work?

Comment 11

[Aaron Train [:aaronmt]]

Attachment: upgrade.log

(In reply to comment #10)
> Have you tried to jump between releases and the latest release candidates? Does
> that work?

Yes, easy_install/pip works great without specifying a hard version number, it finds a best match (which is the latest version):

Reading http://pypi.python.org/simple/mozmill/
Reading http://code.google.com/p/mozmill
Reading http://github.com/mozautomation/mozmill
Reading https://developer.mozilla.org/en/Mozmill
Best match: mozmill 1.5.2rc3

See the upgrade.log attached. I initially had 1.5.1 installed, and executed:

easy_install -U mozmill

After the upgrade, I had 1.5.2rc3, ManifestDestiny-0.2.2, MozRunner 2.5.3rc1, JSBridge 2.4.2rc1

Comment 12

[Aaron Train [:aaronmt]]

Attachment: Patch v2 - mozmill==1.5.1

If we want a fixed version for 1.5.1 at the moment, the following patch works as the dependencies are satisfied and downloaded, and 1.5.1 is installed.

Reminder though, this will need to be updated when 1.5.2 is released. The change would be |easy_install -U mozmill| ... it will download all dependencies including the new ManifestDestiny.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

(In reply to comment #12)
> Reminder though, this will need to be updated when 1.5.2 is released. The
> change would be |easy_install -U mozmill| ... it will download all dependencies
> including the new ManifestDestiny.

No, we will have to use "mozmill==1.5.2", or as discussed we want to go with bug 632362.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 509796 [details] [diff] [review]
Patch v2 - mozmill==1.5.1

>-easy_install -U mercurial mozrunner jsbridge mozmill
>+easy_install mozmill==1.5.1

Why are you removing mercurial?

Comment 15

[Aaron Train [:aaronmt]]

Ah, oversight on my already deployed environment. I will update the patch.

Comment 16

[Aaron Train [:aaronmt]]

Attachment: Patch v3 - mozmill==1.5.1

Added back 'mercurial' module to easy_install package listing for Linux and OS X

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 510633 [details] [diff] [review]
Patch v3 - mozmill==1.5.1

I haven't seen a comment from you why you have removed the -U option, but as testing shows it works also fine and broken packages get repaired. Lets get this checked in.

Comment 18

[Aaron Train [:aaronmt]]

Landed as 
https://github.com/whimboo/mozmill-crowd/commit/6ca6a49c134265e70cbb69f8b23db7085e3a8223

Comment 19

[Aaron Train [:aaronmt]]

As spoken, we want to revert these changes. 

https://github.com/whimboo/mozmill-crowd/commit/6ca6a49c134265e70cbb69f8b23db7085e3a8223

Henrik, with git, is this just 'git revert 6ca6a49' with a message to commit, and then pushing to master?

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

I had to try it on my own but yes, that how it works. I did the backout this time:

https://github.com/whimboo/mozmill-crowd/commit/4e7b7f3f01c5d85302ac34a9555f1a26b25a67ad

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

This is not fixed. We have moved it to a future milestone.

Comment 22

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13229757

Comment 23

[u415141]

Henrik Skupin deleted the linked story in Pivotal Tracker

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Closing as wontfix, now that we want to have fixed versions of all tools. I will file new bugs for upcoming tasks under the Automation component.