Closed
Bug 629756
Opened 14 years ago
Closed 14 years ago
Remove the aboutHome.brandStart string
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b12
People
(Reporter: msucan, Assigned: mak)
Details
(Whiteboard: [about-home][strings removal only])
Attachments
(1 file)
|
755 bytes,
patch
|
Dolske
:
review+
Pike
:
feedback+
Dolske
:
approval2.0+
|
Details | Diff | Splinter Review |
Follow-up bug report from bug 627301 comment 73. We need to remove the aboutHome.brandStart string, since it's no longer used.
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [about-home]
|
|
Assignee | |
Comment 1•14 years ago
|
||
There is no reason we can't do this now, according to Axel leaving in a string or removing it has similar costs for l10n, so it's better removing them to avoid forgetting about it (see bug 630479 comment 20).
Asking approval at the same time since patch is trivial.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #510590 -
Flags: review?(dolske)
Attachment #510590 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [about-home] → [about-home][strings removal only]
|
||
Updated•14 years ago
|
Attachment #510590 -
Flags: review?(dolske)
Attachment #510590 -
Flags: review+
Attachment #510590 -
Flags: approval2.0?
Attachment #510590 -
Flags: approval2.0+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 510590 [details] [diff] [review]
patch v1.0
Axel, ok to proceed with pushing this? (Just asking because I noticed the "last string" message in the newsgroup)
Attachment #510590 -
Flags: feedback?(l10n)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 510590 [details] [diff] [review]
patch v1.0
We'll need to stop finding these, basically. But yeah, let's get this landed.
Attachment #510590 -
Flags: feedback?(l10n) → feedback+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•