bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove the aboutHome.brandStart string

RESOLVED FIXED in Firefox 4.0b12

Status

()

Firefox
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: msucan, Assigned: mak)

Tracking

Trunk
Firefox 4.0b12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [about-home][strings removal only])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Follow-up bug report from bug 627301 comment 73. We need to remove the aboutHome.brandStart string, since it's no longer used.
(Assignee)

Updated

8 years ago
Whiteboard: [about-home]
(Assignee)

Comment 1

8 years ago
Created attachment 510590 [details] [diff] [review]
patch v1.0

There is no reason we can't do this now, according to Axel leaving in a string or removing it has similar costs for l10n, so it's better removing them to avoid forgetting about it (see bug 630479 comment 20).
Asking approval at the same time since patch is trivial.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #510590 - Flags: review?(dolske)
Attachment #510590 - Flags: approval2.0?
(Assignee)

Updated

8 years ago
Whiteboard: [about-home] → [about-home][strings removal only]
Attachment #510590 - Flags: review?(dolske)
Attachment #510590 - Flags: review+
Attachment #510590 - Flags: approval2.0?
Attachment #510590 - Flags: approval2.0+
(Assignee)

Comment 2

8 years ago
Comment on attachment 510590 [details] [diff] [review]
patch v1.0

Axel, ok to proceed with pushing this? (Just asking because I noticed the "last string" message in the newsgroup)
Attachment #510590 - Flags: feedback?(l10n)

Comment 3

8 years ago
Comment on attachment 510590 [details] [diff] [review]
patch v1.0

We'll need to stop finding these, basically. But yeah, let's get this landed.
Attachment #510590 - Flags: feedback?(l10n) → feedback+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ac5bd0a7c1b6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
You need to log in before you can comment on or make changes to this bug.