Closed
Bug 629832
Opened 15 years ago
Closed 15 years ago
Remove unwrapNode from dom-utils module
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [needs-mozmill-1.5.2])
Attachments
(1 file)
|
3.95 KB,
patch
|
gmealer
:
review+
|
Details | Diff | Splinter Review |
Mozmill 1.5.2 will offer native support for unwrapping wrapped XUL elements. That will make our unwrapNode function on dom-utils obsolete. We should remove it in about 2-3 weeks.
|
Assignee | |
Comment 1•15 years ago
|
||
Looks like we can remove it but there are some instances left (i.e. modal dialog) which have to use the utils.unwrapNode function instead.
|
|
Assignee | |
Comment 2•15 years ago
|
||
Not needed anymore. Lets get rid of it.
Comment on attachment 531753 [details] [diff] [review]
Patch v1
Looks fine, land it!
Attachment #531753 -
Flags: review?(gmealer) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/75dd6de8dd86 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/2ef93038f91e (aurora)
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•15 years ago
|
||
Also pushed to beta:
http://hg.mozilla.org/qa/mozmill-tests/rev/a6df62408d3a
|
||
Updated•7 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•