Closed Bug 629841 Opened 9 years ago Closed 9 years ago

Remove padding from .toolbarbutton-1 with menu-button type

Categories

(Firefox :: Theme, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b12

People

(Reporter: fvsch, Assigned: dao)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10) Gecko/20100101 Firefox/4.0b10
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10) Gecko/20100101 Firefox/4.0b10

There is a type of button that seems to have unnecessary margins, with the following effects:
- horizontal spacing between buttons becomes irregular (8px, 10px or 12px depending on the combinations--should be 8px everywhere);
- when in "Use Small Icons" mode, adding one of those buttons to the nav bar makes the nav bar higher than it should be.

The kind of button with the faulty margins is a “combo” button (left part is a simple button, right part shows a drop-down list). It seems it’s only used by extensions, and said extensions include Firebug, Readability, Total Validator and others.

I suspect most buttons have margin-left:4px and margin-right:4px, while the nav bar itself has a global 4px padding. (Implementation might be different, I haven't looked at the code yet.)
The problem buttons have 6px of left/right margin (instead of 4), and perhaps 3px of top/bottom margin instead of 0px (or 7 instead of 4).

Reproducible: Always
Attached image Screenshot of the issue
By the way, I tested with:
- Firefox 4 beta 11pre (nightly 2011-01-28) on OSX: bug still there.
- Firefox 4 beta 11pre (nightly 2011-01-28) on Win7: no similar bug.
Seems specific to the Mac theme.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Margins too big for some buttons in nav bar (combo-buttons?) → Margins too big for type="menu-button" toolbar buttons
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Icons & text mode is affected as well, this takes care of it.
Attachment #508097 - Flags: review?(mstange)
Attachment #508097 - Flags: review?(mstange) → review+
Attachment #508097 - Flags: approval2.0?
Summary: Margins too big for type="menu-button" toolbar buttons → Remove padding from .toolbarbutton-1 with menu-button type
Attachment #508097 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/a4ac9b13eab7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
You need to log in before you can comment on or make changes to this bug.