Drop support for globalCompositeOperation=over,clear

VERIFIED FIXED in mozilla7

Status

()

Core
Canvas: 2D
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla7
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox7+)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
http://www.w3c-test.org/html/tests/approved/canvas/2d.composite.operation.clear.html
Summary: Drop support for globalCompositeOperation=over → Drop support for globalCompositeOperation=over,clear
Er what? Why did these get removed?
(Assignee)

Comment 3

7 years ago
They were never in the spec, AIUI.

For reference:
http://www.whatwg.org/specs/web-apps/2005-09-01/#compositing
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2007-June/012063.html
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2008-January/013804.html
(Assignee)

Comment 4

7 years ago
Created attachment 510678 [details] [diff] [review]
Patch v1
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #510678 - Flags: review?(jonas)
Comment on attachment 510678 [details] [diff] [review]
Patch v1

You're also removing "darker" from the getter. Is that safe since the setter never sets it?
Attachment #510678 - Flags: review?(jonas) → review+
(Assignee)

Comment 6

7 years ago
I just missed the getter in bug 571532. I don't believe that change has an observable effect.
Depends on: 610267
Whiteboard: [needs landing]
(Assignee)

Comment 7

7 years ago
Created attachment 521839 [details] [diff] [review]
Patch for checkin
Attachment #510678 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]

Comment 8

7 years ago
What do other browsers do?
Whiteboard: [not-ready-for-cedar]
(Assignee)

Comment 9

7 years ago
The last time I tested, Chrome supported "clear", IE, and Opera don't. None of Chrome, IE and Opera supported "over". I'm fine with waiting another cycle, as Boris suggested.
No longer depends on: 610267
Keywords: checkin-needed
Whiteboard: [not-ready-for-cedar] → [need gk2.2 ship]
Keywords: dev-doc-needed
(Assignee)

Comment 10

6 years ago
http://hg.mozilla.org/mozilla-central/rev/25508c9bd01c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [need gk2.2 ship]
Target Milestone: --- → mozilla7
We don't actually document these, so I've simply mentioned their removal on Firefox 7 for developers.
Keywords: dev-doc-needed → dev-doc-complete
Depends on: 673307

Updated

6 years ago
tracking-firefox7: --- → +
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I was trying to verify this on the QA side and by loading the page from Comment 1 I get "clear" and a "Passed" result under the "Actual output". Can anyone say what is expected to be seen for the test example in comment 1, or is there another testcase that can be used to verify the fix? Thanks!
(Assignee)

Comment 13

6 years ago
The testcase in comment 1 should have a green background, and say

* Passed

below the image.
Flags: in-testsuite+
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Based on Comment 13 - Verified issue on Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 using the test case provided in Comment 1.

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.