629873 - Disabled Add-ons not sorted alphabetically

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Luke Iliffe (Harlequin99)]

Attachment: Screenshot of issue.

If I have some disabled add-ons they are not always sorted alphabetically. This only seems to occur if one of the disabled add-ons is marked incompatible with minefield. In this case it is always listed above the compatible disabled add-on.

I thought the purpose of bug 624808 was to make a long list of add-ons broken into 2 lists based on their enabled state, each of those lists being sorted alphabetically. If each of the state lists has other criteria (such as compatibility) being taken into account during sorting this makes it more complicated and could make an individual add-on harder to find.

STR:
1. Open New Profile, go to about:addons
2. Search for and install the add-on compatibility reporter, don't restart
2. Search for and install aero window title, restart browser.
3. Install an incompatible add-on, e.g. Undo Closed Tabs Button https://addons.mozilla.org/en-US/firefox/addon/3082/
4. Restart browser
5. Disable aero window title and Undo closed tabs button, restart browser

Expected:
Alphabetically sorted disabled addons (AWT first UCTB underneath)

Actual:
Undo closed tabs button add-on is listed first.

Comment 1

[Luke Iliffe (Harlequin99)]

Aggh! I have just reread bug 624808 comment 0 and it says:

"Instead, add-ons should be grouped with add-ons of similar status, as follows:

1. Top of list view: enabled add-ons
2. Second in list view: incompatible add-ons
3. Third in list view: disabled add-ons
4. Bottom of list view: blocked add-ons"

So this may actually be by design, but it still feels slightly wonky when looking at the list. Would if be clearer without the incompatible grouping, is this a likely category users are going to want to search for?

Comment 2

[Dave Townsend [:mossop]]

This ended up getting fixed by bug 629521

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110210 Firefox/4.0b12pre