629894 - createImageData and getImageData should work for sizes smaller than one pixel

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The spec says
> At least one pixel's worth of image data must be returned.

We fail

http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.imageData.create2.tiny.html

because we use JS_ValueToECMAInt32, afaict.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And <http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.imageData.get.tiny.html>

Comment 2

[Boris Zbarsky [:bzbarsky]]

So we just need to clamp to a lower bound of 1x1?

What should happen if the passed-in values are -5 and 20?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Take the absolute magnitude. I've got a patch for that, but I still need to file.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 5

[Boris Zbarsky [:bzbarsky]]

So 0 is supposed to throw but 0.1 is supposed to round up to 1?

I'd prefer these be explicit == 0 tests if that's what we're testing for.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Right. Will fix.

Comment 7

[Boris Zbarsky [:bzbarsky]]

As that about the == 0 thing, or an answer to my question?  Or both, in separate sentences?

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

To both, indeed.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 518755 [details] [diff] [review]
Patch v2

r=me

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin.

Comment 11

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/projects/cedar/rev/c47b3a690698

Comment 12

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/rev/c47b3a690698

Comment 13

[Eric Shepherd [:sheppy]]

https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#Notes