Remaining updates to removed-files.in post OmniJar landing

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Installer
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Trunk
seamonkey2.1b2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking-seamonkey2.1 b2+)

Details

Attachments

(1 attachment)

v1
1.45 KB, patch
Robert Kaiser
: review+
sgautherie
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
I just tested the diff of files on windows and got:

http://callek.pastebin.mozilla.org/1001755

which is 
./modules
./modules/CrashSubmit.jsm
./modules/dictUtils.js
./modules/DownloadTaskbarProgress.jsm
./modules/WorkerTest.jsm
./modules/WorkerTest_subworker.js
./modules/WorkerTest_worker.js

All existing only in the version that initiated as an update, and 
./defaults/profile
./defaults/profile/panels.rdf

Missing from the updated version...

panels.rdf is part of the NON_OMNIJAR_FILES the defaults/profile is included in the removed-files.in
(Assignee)

Updated

6 years ago
Summary: Remaining updates to package-manifest and removed-files.in post OmniJar landing → Remaining updates to removed-files.in post OmniJar landing
(Assignee)

Comment 1

6 years ago
Created attachment 508185 [details] [diff] [review]
v1

the removal of defaults/profile is my guess on why this wasn't present in an updated build [I suspect its deleting the whole profile directory, even though its a non-empty dir]
Attachment #508185 - Flags: review?(kairo)
(Assignee)

Comment 2

6 years ago
Comment on attachment 508185 [details] [diff] [review]
v1

In this case, I think we can accept serge's review instead of KaiRo's if he gets here faster. Serge has had many changes to this file throughout the past year[s].
Attachment #508185 - Flags: review?(sgautherie.bz)
Blocks: 627417
Comment on attachment 508185 [details] [diff] [review]
v1

>@@ -498,7 +498,6 @@
>-  defaults/profile

Good catch! r+ on this 1st hunk, which was obviously missed in bug 627417.

>@@ -576,17 +575,21 @@

I'll let KaiRo review this 2nd hunk, as he's more familiar with why it's wanted.
Attachment #508185 - Flags: review?(sgautherie.bz) → review+
Severity: normal → major
Status: NEW → ASSIGNED
blocking-seamonkey2.1: --- → ?
Flags: in-testsuite-
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: --- → seamonkey2.1b2

Comment 4

6 years ago
Comment on attachment 508185 [details] [diff] [review]
v1

Looks good to me, thanks for catching the defaults/profile thing!

We also should check if removal of L10n files works correctly in repackaged builds, adriank has found some irregularities there...
Attachment #508185 - Flags: review?(kairo) → review+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
blocking-seamonkey2.1: ? → b2+
Last Resolved: 6 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> We also should check if removal of L10n files works correctly in repackaged
> builds, adriank has found some irregularities there...

Something like porting bug 590953?
You need to log in before you can comment on or make changes to this bug.