Last Comment Bug 629967 - Remaining updates to removed-files.in post OmniJar landing
: Remaining updates to removed-files.in post OmniJar landing
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Installer (show other bugs)
: Trunk
: All All
: -- major (vote)
: seamonkey2.1b2
Assigned To: Justin Wood (:Callek)
:
:
Mentors:
Depends on:
Blocks: 588067 627417
  Show dependency treegraph
 
Reported: 2011-01-29 19:17 PST by Justin Wood (:Callek)
Modified: 2011-01-30 22:34 PST (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
b2+


Attachments
v1 (1.45 KB, patch)
2011-01-29 19:28 PST, Justin Wood (:Callek)
kairo: review+
bugzillamozillaorg_serge_20140323: review+
Details | Diff | Splinter Review

Description Justin Wood (:Callek) 2011-01-29 19:17:15 PST
I just tested the diff of files on windows and got:

http://callek.pastebin.mozilla.org/1001755

which is 
./modules
./modules/CrashSubmit.jsm
./modules/dictUtils.js
./modules/DownloadTaskbarProgress.jsm
./modules/WorkerTest.jsm
./modules/WorkerTest_subworker.js
./modules/WorkerTest_worker.js

All existing only in the version that initiated as an update, and 
./defaults/profile
./defaults/profile/panels.rdf

Missing from the updated version...

panels.rdf is part of the NON_OMNIJAR_FILES the defaults/profile is included in the removed-files.in
Comment 1 Justin Wood (:Callek) 2011-01-29 19:28:39 PST
Created attachment 508185 [details] [diff] [review]
v1

the removal of defaults/profile is my guess on why this wasn't present in an updated build [I suspect its deleting the whole profile directory, even though its a non-empty dir]
Comment 2 Justin Wood (:Callek) 2011-01-29 19:29:36 PST
Comment on attachment 508185 [details] [diff] [review]
v1

In this case, I think we can accept serge's review instead of KaiRo's if he gets here faster. Serge has had many changes to this file throughout the past year[s].
Comment 3 Serge Gautherie (:sgautherie) 2011-01-30 00:34:18 PST
Comment on attachment 508185 [details] [diff] [review]
v1

>@@ -498,7 +498,6 @@
>-  defaults/profile

Good catch! r+ on this 1st hunk, which was obviously missed in bug 627417.

>@@ -576,17 +575,21 @@

I'll let KaiRo review this 2nd hunk, as he's more familiar with why it's wanted.
Comment 4 Robert Kaiser 2011-01-30 06:34:43 PST
Comment on attachment 508185 [details] [diff] [review]
v1

Looks good to me, thanks for catching the defaults/profile thing!

We also should check if removal of L10n files works correctly in repackaged builds, adriank has found some irregularities there...
Comment 5 Serge Gautherie (:sgautherie) 2011-01-30 22:34:56 PST
(In reply to comment #4)
> We also should check if removal of L10n files works correctly in repackaged
> builds, adriank has found some irregularities there...

Something like porting bug 590953?

Note You need to log in before you can comment on or make changes to this bug.