Bookmarks should load asynchronously

RESOLVED EXPIRED

Status

SeaMonkey
Bookmarks & History
RESOLVED EXPIRED
17 years ago
4 years ago

People

(Reporter: Alec Flett, Unassigned)

Tracking

(Blocks: 1 bug, {helpwanted, perf})

Trunk
helpwanted, perf
Dependency tree / graph
Bug Flags:
blocking1.7a -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p-ie/mac])

(Reporter)

Description

17 years ago
Jud's issues with string bundles, and a discussion with Bill yesterday, made me
realize that we're spending some of our startup time opening and parsing the
bookmarks file.. in reality, this should be an async operation that goes on in
the background, hopefully on another thread, and does not stop the main thread
from proceding forward.

What we should do is kick off a URL load at startup, and as data arrives from
the load, we parse it, and build up the in-memory datasource. This means that
the first window can appear before bookmarks are even loaded!

(this might confuse the personal toolbar if we're still having problems building
up toolbar content on-the-fly but that's the subject of another bug)
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: perf
Target Milestone: --- → Future

Comment 1

17 years ago
alec, can you take a look at this for moz 0.9 or 1.0?  We're reading entire 
bookmark file before we diaplay the first window.   It would be great if we can 
load bookmark asynchronously, or delay loading the book mark till after first 
window shows.

Blocks: 7251

Updated

17 years ago
Blocks: 71781
No longer blocks: 7251

Comment 2

17 years ago
nav triage team:

Reassigning to pchen for investigation. Marking nsbeta1+ and mozilla0.9.1
Assignee: alecf → pchen
Status: ASSIGNED → NEW
Keywords: nsbeta1+
Target Milestone: Future → mozilla0.9.1

Comment 3

17 years ago
Along the way of doing startup analysis, I can't see where this is eating too
many cycles. Certainly on my admittitly small amount of bookmarks, loading
doesn't take very long, ~50ms. Also, bookmarks load during loading of
navigator.xul, so I think it's instantiated at the correct place also.

Marking nsbeta1- and future
Keywords: nsbeta1+ → nsbeta1-
Target Milestone: mozilla0.9.1 → Future
renominating. 
Keywords: nsbeta1- → nsbeta1

Comment 5

16 years ago
nav triage team:

Marking nsbeta1+ and mozilla0.9.4
Keywords: nsbeta1 → nsbeta1+
Target Milestone: Future → mozilla0.9.4

Comment 6

16 years ago
I've seen bookmarks being high up on profiles with really big bookmark files.
There are people out there with thousands of bookmarks and I would expect that
to be many seconds of startup time.

Comment 7

16 years ago
nav triage team:

This isn't going to make the mozilla0.9.4 train. Pushing out to mozilla1.0.1
Target Milestone: mozilla0.9.4 → mozilla1.0.1

Comment 8

16 years ago
Pulling back in to mozilla0.9.7
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0.1 → mozilla0.9.7

Updated

16 years ago
OS: Windows 2000 → All
Hardware: PC → All

Updated

16 years ago
Whiteboard: [p-ie/mac]

Comment 9

16 years ago
Ok, I don't think this is as important since we got delayed loading bookmarks.
Also, async loading will make loading bookmarks take even longer. Marking
mozilla1.0.1 and adding helpwanted
Keywords: helpwanted
Target Milestone: mozilla0.9.7 → mozilla1.0.1

Comment 10

16 years ago
how would async loading take "longer"?

Comment 11

16 years ago
mass-reassign bookmarks & open pref perf bugs from pchen to ben
Assignee: pchen → ben
Status: ASSIGNED → NEW

Updated

16 years ago
Blocks: 40609

Updated

16 years ago
Blocks: 62907

Updated

15 years ago
Keywords: nsbeta1

Comment 12

15 years ago
Nav triage team: nsbeta1-
Assignee: ben → varga
Keywords: nsbeta1 → nsbeta1-

Updated

15 years ago
Target Milestone: mozilla1.0.1 → Future

Updated

14 years ago
Flags: blocking1.7a?

Updated

14 years ago
Flags: blocking1.7a? → blocking1.7a-
Product: Browser → Seamonkey
Assignee: Jan.Varga → nobody
Priority: P3 → --
QA Contact: claudius → bookmarks
Target Milestone: Future → ---

Comment 13

9 years ago
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 14

9 years ago
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 15

9 years ago
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 16

9 years ago
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 17

9 years ago
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 18

9 years ago
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 19

8 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.