Closed
Bug 630096
Opened 15 years ago
Closed 15 years ago
Issues with release order in cairo_d2d_finish
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bas.schouten, Assigned: bas.schouten)
Details
Attachments
(1 file)
|
985 bytes,
patch
|
jrmuizel
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
Cairo d2d finish releases the device (and thus free the D3D10 library) before calling the surface destructor. Causing code for objects belonging to the surface to be called after the D3D10 library is no longer loaded. This issue seems to have been exposed by certain recent changes causing some crashes on shutdown for me, this patch fixes this issue for me.
Attachment #508312 -
Flags: review?(jmuizelaar)
Attachment #508312 -
Flags: approval2.0?
|
||
Comment 1•15 years ago
|
||
Comment on attachment 508312 [details] [diff] [review]
Fix cairo_d2d_finish destruction order
Consider this a preemptive a=me. Get this in asap!
Attachment #508312 -
Flags: approval2.0? → approval2.0+
|
||
Comment 2•15 years ago
|
||
Comment on attachment 508312 [details] [diff] [review]
Fix cairo_d2d_finish destruction order
Please add a comment about why the order needs to be a particular way.
Attachment #508312 -
Flags: review?(jmuizelaar) → review+
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•15 years ago
|
||
> // We need to release the device after calling the constructor, since the
I'm guessing your checked in comment meant to say "destructor"...
You need to log in
before you can comment on or make changes to this bug.
Description
•