Closed Bug 630120 Opened 9 years ago Closed 9 years ago

Change discoverURL to /%LOCALE%/%APP%/discovery/pane/%VERSION%/%OS%

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b12
Tracking Status
blocking2.0 --- -

People

(Reporter: Unfocused, Assigned: Unfocused)

References

Details

Attachments

(1 file, 1 obsolete file)

The addons manager will load the following URL for the discovery pane:
https://services.addons.mozilla.org/en-US/firefox/discovery/VERSION/OS/#GUIDS

However, loading that redirects to:
https://services.addons.mozilla.org/en-US/firefox/discovery/pane/VERSION/OS/#GUIDS

(Which has /pane/ inserted into the middle of the URL.)

This means the addons manager can't detect when the base page is still being displayed. So, for bug 628290, clicking on Get Add-ons will *always* reload the page, even when it doesn't need to.

Can the redirect be removed? If that's not simple, then the URL the addons manager loads can be changed.
Sorry, I forgot to file a bug about this. I added /pane/ to the discovery url so that the match-everything /VERSION/OS/ wouldn't conflict with other urls.

Here's the full new discoverURL:

extensions.webservice.discoverURL: https://services.addons.mozilla.org/%LOCALE%/%APP%/discovery/pane/%VERSION%/%OS%

The redirect is going to be there until beta traffic dies off, and then it will be removed along with the code that has to work around it.
Component: Discovery Pane → Add-ons Manager
Product: addons.mozilla.org → Toolkit
QA Contact: discoverypane → add-ons.manager
Summary: Loading discover pane redirects to URL with /pane/ in it → Change discoverURL to /%LOCALE%/%APP%/discovery/pane/%VERSION%/%OS%
blocking2.0: --- → ?
Not a blocker since it really works as is. Would certainly approve a pref change patch though
blocking2.0: ? → -
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) — Splinter Review
Attachment #513345 - Flags: review?(dtownsend)
Attachment #513345 - Flags: review?(dtownsend)
Attachment #513345 - Flags: review+
Attachment #513345 - Flags: approval2.0+
Attachment #513345 - Attachment is obsolete: true
Flags: in-testsuite-
Flags: in-litmus-
Keywords: checkin-needed
Whiteboard: [has patch][needs landing]
http://hg.mozilla.org/mozilla-central/rev/447f9ec41036
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][needs landing] → [has patch]
Target Milestone: --- → mozilla2.0b12
Blocks: 635471
Blocks: 635568
Version: unspecified → Trunk
Whiteboard: [has patch]
Yay, for killing that redirect. Works as expected with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110222 Firefox/4.0b12pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.