630120 - Change discoverURL to /%LOCALE%/%APP%/discovery/pane/%VERSION%/%OS%

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The addons manager will load the following URL for the discovery pane:
https://services.addons.mozilla.org/en-US/firefox/discovery/VERSION/OS/#GUIDS

However, loading that redirects to:
https://services.addons.mozilla.org/en-US/firefox/discovery/pane/VERSION/OS/#GUIDS

(Which has /pane/ inserted into the middle of the URL.)

This means the addons manager can't detect when the base page is still being displayed. So, for bug 628290, clicking on Get Add-ons will *always* reload the page, even when it doesn't need to.

Can the redirect be removed? If that's not simple, then the URL the addons manager loads can be changed.

Comment 1

[Jeff Balogh (:jbalogh)]

Sorry, I forgot to file a bug about this. I added /pane/ to the discovery url so that the match-everything /VERSION/OS/ wouldn't conflict with other urls.

Here's the full new discoverURL:

extensions.webservice.discoverURL: https://services.addons.mozilla.org/%LOCALE%/%APP%/discovery/pane/%VERSION%/%OS%

The redirect is going to be there until beta traffic dies off, and then it will be removed along with the code that has to work around it.

Comment 2

[Dave Townsend [:mossop]]

Not a blocker since it really works as is. Would certainly approve a pref change patch though

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch - ready for checkin

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/447f9ec41036

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yay, for killing that redirect. Works as expected with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110222 Firefox/4.0b12pre