[static ctor]static constructors in nsHTMLTokenizer.cpp

VERIFIED FIXED in mozilla0.8

Status

()

Core
HTML: Parser
P3
normal
VERIFIED FIXED
18 years ago
16 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({topembed+})

Trunk
mozilla0.8
topembed+
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

DESCRIPTION:  There are static constructors used in nsHTMLTokenizer.cpp.  One of
them is in code that's no longer used since vidur's string changes, and the
other is the static object returned by GetTempStack.  I found that GetTempStack
is called under 5 times for a typical small page load, around 10 times for a
typical complex page (http://www.cnn.com/), around 30 times for the bugzilla
query page, and a bit more for very very long pages.  That doesn't seem to be
enough to justify using static constructors, which are against the C++
portability guidelines http://www.mozilla.org/hacking/portable-cpp.html , cause
objects to show up as a leak, and prevent us from running on OpenBSD (bug
49575), and prevents us from doing module unloading (see bug 60709).
Created attachment 20785 [details] [diff] [review]
patch to nsHTMLTokenizer.cpp
Created attachment 20786 [details] [diff] [review]
add nsDeque to leak stats
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla0.8

Comment 3

18 years ago
r=harishd

Comment 4

18 years ago
sr=waterson on both patches.
Fix checked in 2001-01-09 20:04 PST.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
updated qa contact.
QA Contact: janc → bsharma

Comment 7

17 years ago
Marking it verified as per above developer comments.
Status: RESOLVED → VERIFIED

Updated

16 years ago
Keywords: topembed+
You need to log in before you can comment on or make changes to this bug.