63014 - [static ctor]static constructors in nsHTMLTokenizer.cpp

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  There are static constructors used in nsHTMLTokenizer.cpp.  One of
them is in code that's no longer used since vidur's string changes, and the
other is the static object returned by GetTempStack.  I found that GetTempStack
is called under 5 times for a typical small page load, around 10 times for a
typical complex page (http://www.cnn.com/), around 30 times for the bugzilla
query page, and a bit more for very very long pages.  That doesn't seem to be
enough to justify using static constructors, which are against the C++
portability guidelines http://www.mozilla.org/hacking/portable-cpp.html , cause
objects to show up as a leak, and prevent us from running on OpenBSD (bug
49575), and prevents us from doing module unloading (see bug 60709).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to nsHTMLTokenizer.cpp

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: add nsDeque to leak stats

Comment 3

[harishd]

r=harishd

Comment 4

[Chris Waterson]

sr=waterson on both patches.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-01-09 20:04 PST.

Comment 6

[bsharma]

updated qa contact.

Comment 7

[bsharma]

Marking it verified as per above developer comments.