Closed
Bug 630265
Opened 14 years ago
Closed 14 years ago
Bookmarks menu broken in non browser windows
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b11
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: asaf, Assigned: asaf)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [softblocker])
Attachments
(1 file, 1 obsolete file)
|
1.99 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
The bookmarks menu is broken in non browser windows (mac global menubar).
This is a regression from bug 588011.
Attachment #508460 -
Flags: review?(mak77)
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → ?
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #508460 -
Attachment is obsolete: true
Attachment #508472 -
Flags: review?(mak77)
Attachment #508460 -
Flags: review?(mak77)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 508472 [details] [diff] [review]
actually disable the command
Based on IRC discussion browser methods seem to follow this code path.
low risk, fixing a edge case that can happen especially on Mac.
Attachment #508472 -
Flags: review?(mak77) → review+
|
|
||
Updated•14 years ago
|
Attachment #508472 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
Whiteboard: [softblocker]
|
|
||
Updated•14 years ago
|
Attachment #508472 -
Flags: approval2.0?
|
||
Comment 3•14 years ago
|
||
Is this not testable?
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/947ba01d23f3
I'll file a bug.(In reply to comment #3)
> Is this not testable?
We need a test for this mode in general (the hidden window menubar, that is).
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•14 years ago
|
||
also, properly testing native menubar on mac is still a pain I think?
|
|
Assignee | |
Comment 6•14 years ago
|
||
I think we have some magic method in windowutils to ease that pain, but it might no be perfect..
|
||
Updated•14 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•