Closed Bug 630288 Opened 9 years ago Closed 9 years ago
Dump Callback in ns Exception Handler .cpp uses too much stack
Breakpad allocates 8K of stack, and given the two paths it allocates, it uses more than 8K.
This moves these buffers out of the stack.
9 years ago
Comment on attachment 508480 [details] [diff] [review] fix You'll need approval here, but if this is blocking a blocker, then that should be fairly easy. Thanks for finding this!
This is important because the patch in bug 609104 is orange without this fix.
We're sure/pretty sure that if two plugins simultaneously crash, we won't be overwriting these buffers? (Are all crashes processed on the same thread?)
That code path isn't used for plugin crashes, only main process crashes. Breakpad has locking around the exception handling that we use for the main process: http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/linux/handler/exception_handler.cc#258 http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc#433 http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/mac/handler/exception_handler.cc#280
Blocks a blocker, so its a blocker.
Whiteboard: [softblocker] → [softblocker][fixed-in-tracemonkey]
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/6a5665476ee4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.