630288 - MiniDumpCallback in nsExceptionHandler.cpp uses too much stack

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Breakpad allocates 8K of stack, and given the two paths it allocates, it uses more than 8K.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix

This moves these buffers out of the stack.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 508480 [details] [diff] [review]
fix

You'll need approval here, but if this is blocking a blocker, then that should be fairly easy. Thanks for finding this!

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This is important because the patch in bug 609104 is orange without this fix.

Comment 4

[Benjamin Smedberg]

We're sure/pretty sure that if two plugins simultaneously crash, we won't be overwriting these buffers? (Are all crashes processed on the same thread?)

Comment 5

[(not currently active) Ted Mielczarek]

That code path isn't used for plugin crashes, only main process crashes. Breakpad has locking around the exception handling that we use for the main process:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/linux/handler/exception_handler.cc#258
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc#433
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/mac/handler/exception_handler.cc#280

Comment 6

[Andreas Gal :gal]

Blocks a blocker, so its a blocker.

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

http://hg.mozilla.org/tracemonkey/rev/6a5665476ee4

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/6a5665476ee4