630290 - Build warning: "TestObserverArray.cpp:90:123: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

When building mozilla-central with g++ 4.5, I get the following build-spew when I hit TestObserverArray.cpp:
> xpcom/tests/TestObserverArray.cpp:89:43: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:96:43: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:103:43: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:111:43: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:117:43: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:122:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:125:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:131:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:141:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:145:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:156:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:161:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98
> xpcom/tests/TestObserverArray.cpp:164:44: warning: invoking macro DO_TEST argument 3: empty macro arguments are undefined in ISO C90 and ISO C++98

Comment 1

[Atul Aggarwal]

Attachment: Patch v1

This patch removes 55 lines of warnings.

Comment 2

[Atul Aggarwal]

All warnings are like:
/mozilla/mozilla-central/xpcom/tests/TestObserverArray.cpp:90:123: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla/mozilla-central/xpcom/tests/TestTArray.cpp:661:248: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 7 has type ‘size_t {aka long unsigned int}’ [-Wformat]

Comment 3

[Daniel Holbert [:dholbert]]

Note that this bug was about a different set of warnings (in this same file).

However, from looking at a recent build log[1], it looks like Comment 0's warnings have been resolved, so I'm happy to have this bug be about the warnings in Comment 2 now.

[1] https://tbpl.mozilla.org/php/getParsedLog.php?id=7240706&tree=Firefox

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 572301 [details] [diff] [review]
Patch v1

This is OK, but just FYI, the standard C way to printf() size_t is with the "%z" format specifier, which of course MSVC doesn't support :/.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1145823819dc

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1145823819dc