[10.6] Mac "installer" window background doesn't fit

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Installer
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

({fixed-seamonkey2.0.14})

Trunk
seamonkey2.1b3
x86
Mac OS X
fixed-seamonkey2.0.14

Firefox Tracking Flags

(blocking-seamonkey2.1 -, seamonkey2.1 wanted)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 508564 [details]
Screenshot (10.6)

On 10.6, Apple have changed the way the path bar appears at the bottom on windows: it just attaches itself to the bottom, without taking up any content space. Unfortunately, our background-image in the installer window was made to fit exactly with the path bar in the content area - so on 10.6 there's now a blank space at the bottom.

We should fix this on 2.0.x too.

Comment 1

7 years ago
Hmm |background-size: cover;| should future proof things somewhat right?
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> Hmm |background-size: cover;| should future proof things somewhat right?

Ah, this is not our "window" - it's the disk image "window". So, no css magic there, unfortunately - only a .DS_Store file in binary format (with window dimensions, features etc).
(Assignee)

Comment 3

7 years ago
I think we should fix this for final, it looks unprofessional with the current background.
blocking-seamonkey2.1: --- → ?
I agree that it look suboptimal, but its still usable, and has the icons still lining up. I'm not blocking for this, but I will take a patch even on our stable branch if one comes along. I surely do want it though.
blocking-seamonkey2.1: ? → -
status-seamonkey2.1: --- → wanted
(Assignee)

Comment 5

7 years ago
Created attachment 518451 [details] [diff] [review]
Adjust height of window

OK, I *think* this should fix it. I had to edit the file a bit, overwrote some of the my added junk with "x". If you want, you can probably overwrite the "suiterunner" stuff in the file ;-).

Anyway, this should adjust the window height, so we don't have that white space at the bottom. Only tested on 10.6.6. If you don't have a Leopard drive handy, I can probably boot into an old back-up drive with Leopard after a cross-compile (painful, but probably needed).
Assignee: installer → stefanh
Status: NEW → ASSIGNED
Attachment #518451 - Flags: review?(mnyromyr)
(Assignee)

Comment 6

7 years ago
Btw, Mento did some reverse-engineering of the magic .DS_Store file:
https://wiki.mozilla.org/DS_Store_File_Format

Updated

7 years ago
Attachment #518451 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 7

7 years ago
I'll land this when I've tested it on 10.5.
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/comm-central/rev/952c43875cd9 (tested ok on Leopard)
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
(Assignee)

Comment 9

6 years ago
Comment on attachment 518451 [details] [diff] [review]
Adjust height of window

We might want to take this for 2.0.13.
Attachment #518451 - Flags: approval-seamonkey2.0.13?

Updated

6 years ago
Attachment #518451 - Flags: approval-seamonkey2.0.13? → approval-seamonkey2.0.13+
(Assignee)

Comment 10

6 years ago
http://hg.mozilla.org/releases/comm-1.9.1/rev/0705182f6d50
Keywords: fixed-seamonkey2.0.13
(Assignee)

Updated

6 years ago
Target Milestone: seamonkey2.1b2 → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.