Closed Bug 630405 Opened 13 years ago Closed 13 years ago

about:Home breaks due to localstorage not loading

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b11
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: zpao, Assigned: mak)

Details

(Whiteboard: [hardblocker][b11][fx4-fixed-bugday][about-home])

Attachments

(1 file)

patch v1.0
2.25 KB, patch
mayhemer
: review+
Details | Diff | Splinter Review 
Apparently something is doing a case sensitive comparison so while about:home works, about:Home doesn't. The page loads, but the data in localstorage isn't loaded.
blocking2.0: --- → ?
when we use the path to generate a domainScope we should probably make it lowercase. in the common case of usual pages we call GetASCIIHost and it probably returns a always lowercased value.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
blocking2.0: ? → betaN+
Whiteboard: [hardblocker]
Attached patch patch v1.0 — — Splinter Review 

        Attachment #508743 -
        Flags: review?(honzab.moz)
Whiteboard: [hardblocker] → [hardblocker][has patch][needs review honzab]

    
    

    
  
Comment on attachment 508743 [details] [diff] [review]
patch v1.0

Looks good.

r=honzab.

        Attachment #508743 -
        Flags: review?(honzab.moz) → review+
Whiteboard: [hardblocker][has patch][needs review honzab] → [hardblocker][has patch][can land]
Whiteboard: [hardblocker][has patch][can land] → [hardblocker][has patch][can land][b11]

    
    

    
  
Pushed http://hg.mozilla.org/mozilla-central/rev/3fab3dca9817
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [hardblocker][has patch][can land][b11] → [hardblocker][b11]
Target Milestone: --- → Firefox 4.0b11
Flags: in-testsuite+

    
    

    
  
I can verify that both about:Home and about:home work on Firefox 4 Beta 11 on Linux x86_64.

    
  
Status: RESOLVED → VERIFIED
Whiteboard: [hardblocker][b11] → [hardblocker][b11][fx4-fixed-bugday]
Whiteboard: [hardblocker][b11][fx4-fixed-bugday] → [hardblocker][b11][fx4-fixed-bugday][about-home]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: