Closed
Bug 630405
Opened 15 years ago
Closed 15 years ago
about:Home breaks due to localstorage not loading
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 4.0b11
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: zpao, Assigned: mak)
Details
(Whiteboard: [hardblocker][b11][fx4-fixed-bugday][about-home])
Attachments
(1 file)
|
2.25 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
Apparently something is doing a case sensitive comparison so while about:home works, about:Home doesn't. The page loads, but the data in localstorage isn't loaded.
|
Reporter | |
Updated•15 years ago
|
blocking2.0: --- → ?
|
Assignee | |
Comment 1•15 years ago
|
||
when we use the path to generate a domainScope we should probably make it lowercase. in the common case of usual pages we call GetASCIIHost and it probably returns a always lowercased value.
|
|
Assignee | |
Comment 2•15 years ago
|
||
and this makes me think I'm right http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsStandardURL.cpp#1484
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
||
Updated•15 years ago
|
blocking2.0: ? → betaN+
Whiteboard: [hardblocker]
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #508743 -
Flags: review?(honzab.moz)
|
||
Updated•15 years ago
|
Whiteboard: [hardblocker] → [hardblocker][has patch][needs review honzab]
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 508743 [details] [diff] [review]
patch v1.0
Looks good.
r=honzab.
Attachment #508743 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [hardblocker][has patch][needs review honzab] → [hardblocker][has patch][can land]
|
|
||
Updated•15 years ago
|
Whiteboard: [hardblocker][has patch][can land] → [hardblocker][has patch][can land][b11]
|
|
Reporter | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [hardblocker][has patch][can land][b11] → [hardblocker][b11]
Target Milestone: --- → Firefox 4.0b11
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite+
|
|
||
Comment 6•15 years ago
|
||
I can verify that both about:Home and about:home work on Firefox 4 Beta 11 on Linux x86_64.
Status: RESOLVED → VERIFIED
Whiteboard: [hardblocker][b11] → [hardblocker][b11][fx4-fixed-bugday]
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [hardblocker][b11][fx4-fixed-bugday] → [hardblocker][b11][fx4-fixed-bugday][about-home]
You need to log in
before you can comment on or make changes to this bug.
Description
•