630461 - Comparison between signed and unsigned integers in nsBuiltinDecoderStateMachine.cpp

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[cajbir (:cajbir)]

The following compile warnings occur using gcc in nsBuiltinDecoderStateMachine.cpp:

content/media/nsBuiltinDecoderStateMachine.cpp: In member function ‘void nsBuiltinDecoderStateMachine::DecodeLoop()’:
content/media/nsBuiltinDecoderStateMachine.cpp:254: warning: comparison between signed and unsigned integer expressions
content/media/nsBuiltinDecoderStateMachine.cpp:275: warning: comparison between signed and unsigned integer expressions
content/media/nsBuiltinDecoderStateMachine.cpp:282: warning: comparison between signed and unsigned integer expressions
content/media/nsBuiltinDecoderStateMachine.cpp:332: warning: comparison between signed and unsigned integer expressions

Comment 1

[cajbir (:cajbir)]

Attachment: fix

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 508676 [details] [diff] [review]
fix

Looks good. Can you move the "{" in multiline if statements to the start of following line, to line up with their "if", as is the convention in the rest of that file? Thanks!

Comment 3

[cajbir (:cajbir)]

Attachment: fix

Change 'if' style to match rest of file as per review comment. r+ carried forward.

Comment 4

[cajbir (:cajbir)]

Comment on attachment 508972 [details] [diff] [review]
fix

Requesting approval to land this minor patch to remove compiler warnings.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 508972 [details] [diff] [review]
fix

Instead of static_cast<PRUint32>, use PRUint32(...). It's shorter!

Comment 6

[cajbir (:cajbir)]

http://hg.mozilla.org/mozilla-central/rev/81dec7f81e69