630518 - l10n verify, update verify, and final verification builders need to set "branch" when reporting to clobberer

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect, P2)

Description

[[e-mail] (:bhearsum)]

Currently they don't, which is bad for two reasons:
1) It's inconsistent with all the other builders
2) They won't get clobbered when we clobber by branch

This isn't high priority because these builders clobber themselves at the start of a build.

Comment 1

[Rail Aliiev [:rail]]

Shouldn't be hard, setting branchName should help.

Comment 2

[Rail Aliiev [:rail]]

Attachment: pass repo path

Not tested yet. Update verify doesn't use clobberer.

Comment 3

[Rail Aliiev [:rail]]

Attachment: use branches

Checking clobber URL: http://build.mozilla.org/stage-clobberer/index.php?master=http%3A%2F%2Fdev-master01.build.scl1.mozilla.com%3A8033%2F&slave=linux-ix-slave04&builddir=rel-m-rel-osx64-fnl-verf&branch=mozilla-release&buildername=release-mozilla-release-macosx64_final_verification

Backward compatible patch. If you prefer I can just remove the extra check and make the factories require repoPath.

Comment 4

[Rail Aliiev [:rail]]

l10n verify sets branch as well:
Checking clobber URL: http://build.mozilla.org/stage-clobberer/index.php?master=http%3A%2F%2Fdev-master01.build.scl1.mozilla.com%3A8033%2F&slave=moz2-darwin10-slave01&builddir=rel-m-rel-lnx-l10n-verification&branch=mozilla-release&buildername=release-mozilla-release-linux_l10n_verification

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 604909 [details] [diff] [review]
use branches

Review of attachment 604909 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/factory.py
@@ +5447,5 @@
>      def __init__(self, verifyConfigs, platforms=None, **kwargs):
>          # MozillaBuildFactory needs the 'repoPath' argument, but we don't
> +        if 'repoPath' not in kwargs:
> +            kwargs['repoPath'] = 'nothing'
> +        ReleaseFactory.__init__(self, **kwargs)

Do we have any cases where repoPath won't be set here or in l10n verify? What happens to the clobberer data when it gets a branch of 'nothing'? Does it show up on the webpage?

Comment 6

[Rail Aliiev [:rail]]

(In reply to Ben Hearsum [:bhearsum] from comment #5)

> Do we have any cases where repoPath won't be set here or in l10n verify?

No, that's to not force tb, sm, calendar to use the new schema. Probably forcing won't be a bad idea.

> What happens to the clobberer data when it gets a branch of 'nothing'? Does
> it show up on the webpage?

These builders are safe to be run even without clobbering. I couldn't find any special cases for 'nothing' in clobberer nor other places.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 604909 [details] [diff] [review]
use branches

Review of attachment 604909 [details] [diff] [review]:
-----------------------------------------------------------------

OK, this should be fine then.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 604909 [details] [diff] [review]
use branches

http://hg.mozilla.org/build/buildbotcustom/rev/9154a9aa253b

Comment 9

[Aki Sasaki (not active)]

Reconfiged x2.