Closed
Bug 630601
Opened 15 years ago
Closed 15 years ago
Comment in LIR.cpp contains non-ASCII char, causing some Windows compilers to complain
Categories
(Core Graveyard :: Nanojit, defect)
Core Graveyard
Nanojit
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Unassigned)
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)
Attachments
(1 file)
|
996 bytes,
patch
|
n.nethercote
:
review+
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Apparently, some versions of Visual Studio will refuse to compile this file on systems that have a default codepage of anything other than Latin1.
(Instead of a hyphen, ascii 2D, the file contains the UTF8 sequence E2 88 92)
Attachment #508818 -
Flags: review?(edwsmith)
|
Reporter | |
Updated•15 years ago
|
Attachment #508818 -
Flags: review?(nnethercote)
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 508818 [details] [diff] [review]
Patch
How did that get in there?
BTW, I don't think this patch needs two reviews :)
Attachment #508818 -
Flags: review?(edwsmith) → review+
|
|
||
Updated•15 years ago
|
Attachment #508818 -
Flags: review?(nnethercote) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
I don't either, just seeing who's r+ it first :-)
|
|
Reporter | |
Comment 3•15 years ago
|
||
pushed to nanojit-central as 1485:09de25da6b95
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•15 years ago
|
||
changeset: 6017:61c09252cd6e
user: Steven Johnson <stejohns@adobe.com>
summary: Bug 630601 - Comment in LIR.cpp contains non-ASCII char (r=nnethercote)
http://hg.mozilla.org/tamarin-redux/rev/61c09252cd6e
|
|
||
Comment 5•15 years ago
|
||
Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
|
|
||
Comment 7•15 years ago
|
||
(In reply to comment #6)
> I think this is missing a comment for the mozilla-central push.
http://hg.mozilla.org/mozilla-central/rev/26ca4473084a
|
Assignee | |
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•