Closed Bug 630601 Opened 12 years ago Closed 12 years ago

Comment in LIR.cpp contains non-ASCII char, causing some Windows compilers to complain

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stejohns, Unassigned)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)

Attachments

(1 file)

Patch
996 bytes, patch
n.nethercote
: review+
n.nethercote
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
Apparently, some versions of Visual Studio will refuse to compile this file on systems that have a default codepage of anything other than Latin1. 

(Instead of a hyphen, ascii 2D, the file contains the UTF8 sequence E2 88 92)
Attachment #508818 - Flags: review?(edwsmith)
Attachment #508818 - Flags: review?(nnethercote)
Comment on attachment 508818 [details] [diff] [review]
Patch

How did that get in there?

BTW, I don't think this patch needs two reviews :)
Attachment #508818 - Flags: review?(edwsmith) → review+
Attachment #508818 - Flags: review?(nnethercote) → review+
I don't either, just seeing who's r+ it first :-)
pushed to nanojit-central as 1485:09de25da6b95
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
changeset: 6017:61c09252cd6e
user:      Steven Johnson <stejohns@adobe.com>
summary:   Bug 630601 - Comment in LIR.cpp contains non-ASCII char (r=nnethercote)

http://hg.mozilla.org/tamarin-redux/rev/61c09252cd6e
http://hg.mozilla.org/tracemonkey/rev/26ca4473084a
Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
I think this is missing a comment for the mozilla-central push.
(In reply to comment #6)
> I think this is missing a comment for the mozilla-central push.

http://hg.mozilla.org/mozilla-central/rev/26ca4473084a
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.