630633 - Option to rebuild N times with self-serve

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[Chris AtLee [:catlee]]

It would be really useful to be able to rebuild something a certain number of times, waiting for the job to start each time before triggering another job.

Comment 1

[Ed Morley [:emorley]]

<ehsan> catlee: can I bribe someone to fix that please? :)
<edmorley> it's something that would save me time too fwiw
<ehsan> catlee: or can you tell me how to fix it if it's easy?
<catlee> http://hg.mozilla.org/build/buildapi/file/7b75f9e93580/buildapi/controllers/selfserve.py#l372 (and the method below) need to look for a 'n_retries' parameter
<catlee> http://hg.mozilla.org/build/buildapi/file/7b75f9e93580/buildapi/scripts/selfserve-agent.py#l289 needs to act on it
<ehsan> catlee: how does one test this stuff locally?
<catlee> and then probably some UI changes unless you like hitting the API directly

Comment 2

[Ed Morley [:emorley]]

catlee> UI is here - http://hg.mozilla.org/build/buildapi/file/7b75f9e93580/buildapi/templates/self-serve/branch.mako#l102

Comment 3

[Chris AtLee [:catlee]]

Attachment: retries-buildapi.patch

gently tested...but what could go wrong?

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8410989 [details] [diff] [review]
retries-buildapi.patch

Review of attachment 8410989 [details] [diff] [review]:
-----------------------------------------------------------------

with the described change

::: buildapi/controllers/selfserve.py
@@ +390,5 @@
>          except formencode.Invalid:
>              return self._failed('Bad priority', 400)
>  
> +        try:
> +            count = validators.Int(if_empty=0).to_python(request.POST.get('count'))

Shouldn't this be `if_empty=1`?  I see that it defaults to 1 on the agent if missing, but the docstring describes a default for the POST.

@@ +426,5 @@
>          except formencode.Invalid:
>              return self._failed('Bad priority', 400)
>  
> +        try:
> +            count = validators.Int(if_empty=0).to_python(request.POST.get('count'))

ditto

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 8410989 [details] [diff] [review]
retries-buildapi.patch

Fixed the default count if not submitted; also fixed the fields submitted for rebuilding requests.

Comment 6

[Chris AtLee [:catlee]]

Attachment: deploy new version of agent

Comment 7

[Chris AtLee [:catlee]]

Comment on attachment 8412102 [details] [diff] [review]
deploy new version of agent

and merged to production

Comment 8

[Chris AtLee [:catlee]]

Looks like this is live!

Give it a spin!

Comment 9

[(no longer active)]

Thanks *so much* Chris!