Closed
Bug 630633
Opened 13 years ago
Closed 10 years ago
Option to rebuild N times with self-serve
Categories
(Release Engineering :: General, defect, P5)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
Details
(Keywords: buildapi, sheriffing-P2)
Attachments
(2 files)
20.09 KB,
patch
|
dustin
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
919 bytes,
patch
|
dustin
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
It would be really useful to be able to rebuild something a certain number of times, waiting for the job to start each time before triggering another job.
Updated•13 years ago
|
OS: Linux → All
Priority: -- → P5
Hardware: x86_64 → All
Whiteboard: [self-serve] → [self-serve][automation]
Updated•11 years ago
|
Whiteboard: [self-serve][automation]
Updated•11 years ago
|
Keywords: sheriffing-P2
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Comment 1•10 years ago
|
||
<ehsan> catlee: can I bribe someone to fix that please? :) <edmorley> it's something that would save me time too fwiw <ehsan> catlee: or can you tell me how to fix it if it's easy? <catlee> http://hg.mozilla.org/build/buildapi/file/7b75f9e93580/buildapi/controllers/selfserve.py#l372 (and the method below) need to look for a 'n_retries' parameter <catlee> http://hg.mozilla.org/build/buildapi/file/7b75f9e93580/buildapi/scripts/selfserve-agent.py#l289 needs to act on it <ehsan> catlee: how does one test this stuff locally? <catlee> and then probably some UI changes unless you like hitting the API directly
Comment 2•10 years ago
|
||
catlee> UI is here - http://hg.mozilla.org/build/buildapi/file/7b75f9e93580/buildapi/templates/self-serve/branch.mako#l102
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → catlee
Assignee | ||
Comment 3•10 years ago
|
||
gently tested...but what could go wrong?
Attachment #8410989 -
Flags: review?(dustin)
Comment 4•10 years ago
|
||
Comment on attachment 8410989 [details] [diff] [review] retries-buildapi.patch Review of attachment 8410989 [details] [diff] [review]: ----------------------------------------------------------------- with the described change ::: buildapi/controllers/selfserve.py @@ +390,5 @@ > except formencode.Invalid: > return self._failed('Bad priority', 400) > > + try: > + count = validators.Int(if_empty=0).to_python(request.POST.get('count')) Shouldn't this be `if_empty=1`? I see that it defaults to 1 on the agent if missing, but the docstring describes a default for the POST. @@ +426,5 @@ > except formencode.Invalid: > return self._failed('Bad priority', 400) > > + try: > + count = validators.Int(if_empty=0).to_python(request.POST.get('count')) ditto
Attachment #8410989 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8410989 [details] [diff] [review] retries-buildapi.patch Fixed the default count if not submitted; also fixed the fields submitted for rebuilding requests.
Attachment #8410989 -
Flags: checked-in+
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8412102 -
Flags: review?(dustin)
Updated•10 years ago
|
Attachment #8412102 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8412102 [details] [diff] [review] deploy new version of agent and merged to production
Attachment #8412102 -
Flags: checked-in+
Assignee | ||
Comment 8•10 years ago
|
||
Looks like this is live! Give it a spin!
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 9•10 years ago
|
||
Thanks *so much* Chris!
You need to log in
before you can comment on or make changes to this bug.
Description
•