630635 - [@~nsFilePicker] crashes on close

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tatiana Meshkova (:tatiana)]

backtrace:

#0  0x00979422 in __kernel_vsyscall ()
#1  0x007b7ce6 in nanosleep () from /lib/tls/i686/cmov/libc.so.6
#2  0x007b7b10 in sleep () from /lib/tls/i686/cmov/libc.so.6
#3  0x011cfae9 in ah_crap_handler (signum=11)
    at mozilla-central/toolkit/xre/nsSigHandlers.cpp:132
#4  0x011d39bb in nsProfileLock::FatalSignalHandler (signo=11, 
    info=0xbf9a424c, context=0xbf9a42cc) at nsProfileLock.cpp:226
#5  <signal handler called>
#6  0x00000004 in ?? ()
#7  0x0253d9d1 in ~nsFilePicker (this=0x9a22210, 
    __in_chrg=<value optimized out>)
    at mozilla-central/widget/src/qt/nsFilePicker.cpp:74
#8  0x0253d5a9 in nsFilePicker::Release (this=0x9a22210)
    at mozilla-central/widget/src/qt/nsFilePicker.cpp:60
#9  0x0208ad0f in DoDeferredRelease<nsISupports*> (array=...)
    at mozilla-central/js/src/xpconnect/src/xpcjsruntime.cpp:574
#10 0x02087f6b in XPCJSRuntime::GCCallback (cx=0x92fbc68, status=JSGC_END)
    at mozilla-central/js/src/xpconnect/src/xpcjsruntime.cpp:883
#11 0x01b09567 in DOMGCCallback (cx=0x92fbc68, status=JSGC_END)
    at mozilla-central/dom/base/nsJSEnvironment.cpp:3594
#12 0x02b50eb2 in js_GC (cx=0x92fbc68, comp=0x0, gckind=GC_NORMAL)
    at mozilla-central/js/src/jsgc.cpp:2804
#13 0x02ac700f in JS_GC (cx=0x92fbc68)
    at mozilla-central/js/src/jsapi.cpp:2565
#14 0x011cba8b in nsXREDirProvider::DoShutdown (this=0xbf9a48fc)
    at mozilla-central/toolkit/xre/nsXREDirProvider.cpp:811
#15 0x011b98d6 in ~ScopedXPCOMStartup (this=0xbf9a4a38, 
    __in_chrg=<value optimized out>)
    at mozilla-central/toolkit/xre/nsAppRunner.cpp:1114
#16 0x011c17b8 in XRE_main (argc=3, argv=0xbf9a4db4, aAppData=0x87309e8)
    at mozilla-central/toolkit/xre/nsAppRunner.cpp:3805
#17 0x08048de7 in main (argc=3, argv=0xbf9a4db4)
    at mozilla-central/browser/app/nsBrowserApp.cpp:158

Comment 1

[Tatiana Meshkova (:tatiana)]

Attachment: patch

allow Qt to handle delete

Comment 2

[Tatiana Meshkova (:tatiana)]

Attachment: patch

Comment 3

[Tatiana Meshkova (:tatiana)]

Attachment: patch v3

arr, DeleteOnClose flag should not be used with QDialogs, it causes:

==12575== Mismatched free() / delete / delete []
==12575==    at 0x4024851: operator delete(void*) (vg_replace_malloc.c:387)
==12575==    by 0x7561F04: QFileDialog::~QFileDialog() (in /usr/lib/libQtGui.so.4.6.2)
==12575==    by 0x754E56F: QDialog::exec() (in /usr/lib/libQtGui.so.4.6.2)
==12575==    by 0x570A324: nsFilePicker::Show(short*) (nsFilePicker.cpp:240)
==12575==    by 0x5AB3364: NS_InvokeByIndex_P (xptcinvoke_gcc_x86_unix.cpp:69)
==12575==    by 0x527BF46: CallMethodHelper::Invoke() (xpcwrappednative.cpp:3071)
==12575==    by 0x5279FD2: CallMethodHelper::Call() (xpcwrappednative.cpp:2335)
...

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 509233 [details] [diff] [review]
patch v3

yep, this patch looks more clear

Comment 5

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/8c8a1ef2a816