630693 - Web console's copying adds extra newline between groups.

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Adam]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100729 Iceweasel/3.6.7 (like Firefox/3.6.7)
Build Identifier: 4.0b11pre (2011-02-01)

toolkit/components/console/hudservice/HUDService.jsm:copySelectedItems():2860 calls strings.push("\n"), and then later strings.join("\n").  That means there are extra newlines being inserted.

Reproducible: Always

Steps to Reproduce:
1. Make sure multiple lines in the web console
2. cmd+A
3. cmd+C
4. Paste in a text editor
Actual Results:  
Groups are separated by two newlines.

Expected Results:  
Groups are separated by single newline.

I'll attach a patch as well, but the only thing other than removing the newline from the push() is updating the comment above it.

Comment 1

[Adam]

Attachment: Removes extra newline and updates the comment.

Comment 2

[Rob Campbell [:rc] (:robcee)]

this will be fixed by bug 611795.

Comment 3

[Kevin Dangoor]

I thought this behavior was actually intentional to make it easier to spot request boundaries. cc'ing Patrick to see what he thinks.

Comment 4

[Rob Campbell [:rc] (:robcee)]

that may be, but I thought it looked messy. I've replaced the extra newline with a couple of dashes.

Comment 5

[Patrick Walton (:pcwalton)]

Yeah, it was intentional (I think... been a while). Feel free to change it though.

Comment 6

[Rob Campbell [:rc] (:robcee)]

I don't believe this bug was fixed, probably lost those bits along the review path. I'd like to update this patch so it applies cleanly and instead of replacing the newline with an empty string, replace it with a pair of dashes to indicate separation.

Adam, did you want to update it?

Comment 7

[Adam]

Attachment: [checked-in] Replace newline with a pair of dashes, updates comment.

I didn't add a test, but can do so if needed.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 515255 [details] [diff] [review]
[checked-in] Replace newline with a pair of dashes, updates comment.

Awesome thanks!

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 515255 [details] [diff] [review]
[checked-in] Replace newline with a pair of dashes, updates comment.

r+a=beltzner, trivial patch with strong benefit

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 515255 [details] [diff] [review]
[checked-in] Replace newline with a pair of dashes, updates comment.

http://hg.mozilla.org/mozilla-central/rev/51aca1e8e3f8

Comment 11

[Rob Campbell [:rc] (:robcee)]

Thanks so much for the patch, Adam!

Comment 12

[Maniac Vlad Florin (:vladmaniac)]

Verified