Closed Bug 630728 Opened 13 years ago Closed 12 years ago

Intermittent test_webgl_conformance_test_suite.html | Test expected to fail, but passed: conformance/textures/texture-npot.html

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
mozilla10

People

(Reporter: philor, Assigned: bjacob)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

silence this test
1.77 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
From bug 627586 comment 8:

wjohnston%mozilla.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296495336.1296496206.18462.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test mochitests-1/5 on
2011/01/31 09:35:36

s: talos-r3-snow-020
35922 ERROR TEST-UNEXPECTED-FAIL |
/tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Test
expected to fail, but passed: conformance/texture-npot.html

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296605667.1296607953.26009.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test mochitests-1/5 on 2011/02/01 16:14:27
s: talos-r3-snow-036

35915 ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Test expected to fail, but passed: conformance/texture-npot.html
This test seems to be solid-passing with the latest patch in bug 684882.
Depends on: CVE-2011-3653
I think it's time to do 2 things:
  1. silence this test on test slaves. No point asking more people to star oranges.
  2. investigate by getting a test slave loaned to me. The problem occurs on more than one test slave: at least talos-r3-snow-025 and talos-r3-snow-047.
Attached patch silence this test (obsolete) — — Splinter Review 
I do not at all think that this test is just noise. On the contrary, the fact that a patch made for bug 684882 fixes it is an indication that we should care about it. But as explained in previous comment, this is now being looked at and there is no need to bother more people about it.
Attachment #562938 - Flags: review?(ehsan)
oops... previous patch marked this test as expected to pass, instead of silencing it.
Attachment #562938 - Attachment is obsolete: true
Attachment #562939 - Flags: review?(ehsan)
Attachment #562938 - Flags: review?(ehsan)
Attachment #562939 - Flags: review?(ehsan) → review+
Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ac448885299
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/9ac448885299
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I couldn't come up with enough of a theory to explain that failure in comment 100 to even start at filing a bug. Services-Central has indeed merged the patch from here, and yet it somehow managed to expect conformance/texture-npot.html to fail.
(In reply to Phil Ringnalda (:philor) from comment #101)
> I couldn't come up with enough of a theory to explain that failure in
> comment 100 to even start at filing a bug. Services-Central has indeed
> merged the patch from here, and yet it somehow managed to expect
> conformance/texture-npot.html to fail.

Benoit, could you please investigate?
Assignee: nobody → bjacob
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 693703
Summary: Intermittent test_webgl_conformance_test_suite.html | Test expected to fail, but passed: conformance/texture-npot.html → Intermittent test_webgl_conformance_test_suite.html | Test expected to fail, but passed: conformance/textures/texture-npot.html
Mass marking whiteboard:[orange] bugs WFM (to clean up TBPL bug suggestions) that:
* Haven't changed in > 6months
* Whose whiteboard contains none of the strings: {disabled,marked,random,fuzzy,todo,fails,failing,annotated,leave open,time-bomb}
* Passed a (quick) manual inspection of bug summary/whiteboard to ensure they weren't a false positive.

I've also gone through and searched for cases where the whiteboard wasn't labelled correctly after test disabling, by using attachment description & basic comment searches. However if the test for which this bug was about has in fact been disabled/annotated/..., please accept my apologies & reopen/mark the whiteboard appropriately so this doesn't get re-closed in the future (and please ping me via IRC or email so I can try to tweak the saved searches to avoid more edge cases).

Sorry for the spam! Filter on: #FFA500
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → WORKSFORME
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: