Closed Bug 630891 Opened 9 years ago Closed 9 years ago

nsSubDocumentFrames are always repainted when they move

Categories

(Core :: Web Painting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: pcwalton, Assigned: pcwalton)

Details

Attachments

(1 file)

nsSubDocumentFrames seem to always be repainted in full when they move:

http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsSubDocumentFrame.cpp#677

This means that animating them via -moz-transform can never get the benefit of retained layers.

Do we need this anymore? The comment seems to indicate otherwise...
Looks like that code originates from bug 124507. Where it seems it was extra debugging code accidentally checked in, the mistake was noticed, and a backout patch was made, but the backout patch never got checked in.
Removed and testing on try.
(In reply to comment #0)
> nsSubDocumentFrames seem to always be repainted in full when they move:

ITYM "even when they DON'T move"

Great catch, by the way.
(In reply to comment #3)
> (In reply to comment #0)
> > nsSubDocumentFrames seem to always be repainted in full when they move:
> 
> ITYM "even when they DON'T move"
> 
> Great catch, by the way.

Well, I meant when they do move, under -moz-transform. Animating e.g. an iframe via a transition on -moz-transform does move the iframe, but it shouldn't repaint with retained layers AIUI.
Attached patch Proposed patch.Splinter Review
Here's a patch. Seems to work on try.
Assignee: nobody → pwalton
Status: NEW → ASSIGNED
Attachment #509225 - Flags: review?(roc)
Comment on attachment 509225 [details] [diff] [review]
Proposed patch.

We'd better get this in for a beta.
Attachment #509225 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/b0325a41a167
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.