Closed Bug 630904 Opened 9 years ago Closed 9 years ago

release_sanity should wait for reconfig to finish successfully before doing sendchange

Categories

(Release Engineering :: General, defect, P2, critical)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhford, Assigned: rail)

References

Details

(Whiteboard: [releases][automation])

Attachments

(2 files)

or it shouldn't do the reconfig at all.
I'd add --reconfig (default=False).
Personally, I'd like to see it doing reconfigs still...it's a good safeguard to have. But if that's too difficult to do immediately, disabling them is definitely good.
If it doesn't do the reconfig, it shouldn't do the sendchange either.
(In reply to comment #4)
> If it doesn't do the reconfig, it shouldn't do the sendchange either.

I'm not sure I follow....having it do the sendchange is still good IMHO, because it makes it impossible for us to typo in it.
(In reply to comment #5)
> (In reply to comment #4)
> > If it doesn't do the reconfig, it shouldn't do the sendchange either.
> 
> I'm not sure I follow....having it do the sendchange is still good IMHO,
> because it makes it impossible for us to typo in it.

The whole point of release_sanity is to make sure the master is in a good state before kicking things off.  If it doesn't do the reconfig, it doesn't know if the files on disk have any relation to what the master is running.
I thought the point was to reduce opportunity for manual error. In any case, you seem to feel strongly about this so I'm not going to push back. If it's not doing the sendchange it should at least spit out the "buildbot sendchange" line for you to copy and paste from.
(In reply to comment #7)
> I thought the point was to reduce opportunity for manual error. In any case,
> you seem to feel strongly about this so I'm not going to push back. If it's not
> doing the sendchange it should at least spit out the "buildbot sendchange" line
> for you to copy and paste from.

I think it should be doing both the reconfig and the sendchange.  We just need to add smarts to make sure it waits for the reconfig to finish.
Priority: -- → P3
Whiteboard: [releases][automation]
Assignee: nobody → rail
Priority: P3 → P2
Severity: normal → critical
Attachment #516843 - Flags: review?(catlee)
Worked fine in staging.
Attachment #516843 - Flags: review?(catlee) → review+
Attachment #516842 - Flags: review?(catlee) → review+
Comment on attachment 516843 [details] [diff] [review]
Use buildbot-wrangler.py for reconfig

http://hg.mozilla.org/build/tools/rev/a1acec433bbb
Attachment #516843 - Flags: checked-in+
Comment on attachment 516842 [details] [diff] [review]
Move buildbot-wrangler.py manage_masters.py master_fabric.py to tools

http://hg.mozilla.org/build/braindump/rev/1b5befc79b85
Attachment #516842 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.