630935 - Mac OOPP implementation needs to make Carbon support status (NPNVsupportsCarbonBool) available

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

Attachment: fix v1.0

Our OOPP implementation needs to support the "NPNVsupportsCarbonBool" variable so that plugins can find out that Carbon is not supported.

Comment 1

[Benoit Girard (:BenWa)]

I'm not sure I follow why we decided to ifndef with "NP_NO_QUICKDRAW" and likewise I'm not sure why we want to ifndef NP_NO_CARBON. From the point of view of the plugin they should a valid result regardless of with which flags the build of firefox is compiled rather then relying on them to infer that NP_GENERIC_ERROR => not supported.

The only explanation I can see however that the variable is similarly ifndef-ed in npapi.h.

With this path/implementation I don't see how where gaining anything because plugins still have to handle false/generic_error the same way so we're not giving vendors anything valuable with this change.

Comment 2

[Josh Aas]

I'm doing it this way because that's how it's handled in the NPAPI headers - my patch needs those ifdefs or it won't compile in 64-bit builds. This alone makes it the expedient fix. Those ifdefs also help people catch bugs when they have logic that depends on certain variables that don't make sense in a given architecture.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 509164 [details] [diff] [review]
fix v1.0

Discussed my review comments over IRC. I'm satisfied.

Comment 4

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e9c5611100b7