63108 - Imported address books not showing localized name

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect, P3)

Description

[Karl Ove Hufthammer]

When I import an Outlook Express (probably others too) address book using a 
localized version of Mozilla (2000-12-15), I get a new address book 
named 'Outlook Express Address Book'. This should be localizable, e.g. for my 
Norwegian language pack, it should be 'Outlook Express-adressebok'.

Comment 1

[Karl Ove Hufthammer]

Adding keywords.

Comment 2

[rchen]

Reassigned to ftang.

Comment 3

[Frank Tang]

I search the string "Outlook Express Address Book"
and the result is in
http://lxr.mozilla.org/seamonkey/search?string=Outlook+Express+Address+Book
The guilty code is in
/mailnews/import/oexpress/nsOEImport.cpp, line 553 -- nsString str;
str.AppendWithConversion("Outlook Express address book (windows address book)");
/mailnews/import/oexpress/nsOEImport.cpp, line 581 -- nsString str;
str.AppendWithConversion("Outlook Express Address Book");
/mailnews/import/oexpress/nsOEImport.cpp, line 632 -- IMPORT_LOG0( "IMPORTING
OUTLOOK EXPRESS ADDRESS BOOK\n");

which submit by tonyr%fbdesigns.com
Reassign this bug to [e-mail]

Comment 4

[scottputterman]

reassigning to chuang.

Comment 5

[Teruko Kobayashi]

Changed QA contact to [e-mail] and cc'd [e-mail].

Comment 6

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9

Comment 7

[chuang]

Reassign to Tony.

Comment 8

[scottputterman]

reassigning to chuang. Candice, can you take a look at this one?

Comment 9

[scottputterman]

moving to mozilla0.9.1

Comment 10

[scottputterman]

moving to 0.9.2

Comment 11

[scottputterman]

moving to 0.9.3

Comment 12

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 13

[Scott MacGregor]

sr=mscott

Comment 14

[(not reading, please use [e-mail] instead)]

re-assign to hewitt.

r=sspitzer

Comment 15

[(not reading, please use [e-mail] instead)]

actually, any reason those nsStrings could be on the stack instead of the heap?

(nsAutoString vs nsString)

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

a=roc on behalf of drivers

Comment 17

[nhottanscp]

r=nhotta

Comment 18

[Joe Hewitt (gone)]

fixed

Comment 19

[marina]

Xianglan, if you have OE JA, could you verify this one with JA build? Thanks.

Comment 20

[ji]

Checked address book import from OE5.5-J to NS6.1 Japanese build based on 07/05 
branch build. "Outlook Express Address Book" shows in English after import.
But since this Japanese build has a lot of English strings left and it's only 
used for functionality testing, I'll leave this as unverifed until I check it 
on a Japanese build which is good for UI testing.
QA contact to myself.

Comment 21

[ji]

Verified with NS6.1 Ja build. It's localizable now.