Closed
Bug 631115
Opened 13 years ago
Closed 13 years ago
Make about:home search field re-use autocomplete values from the old page
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b12
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | .x+ |
People
(Reporter: mak, Assigned: mak)
Details
(Keywords: regression, Whiteboard: [about-home])
Attachments
(1 file)
|
917 bytes,
patch
|
Dolske
:
review+
Dolske
:
approval2.0+
|
Details | Diff | Splinter Review |
Connor suggested to set name="q" on the search field in about:home to reuse old autocomplete data. Losing that data is indeed a regression from what we have in FX3.6 While we investigate bug 612453 (making decent and sexy autocomplete code could not be that trivial) this sounds like a really simple fix that could make the release.
|
Assignee | |
Comment 1•13 years ago
|
||
asking softblocking because sounds like a simple, safe and sensible thing to do if we can't make a good suggest code in time.
blocking2.0: --- → ?
|
||
Comment 2•13 years ago
|
||
Doesn't block, but if it's that simple, a patch would be approved.
blocking2.0: ? → .x
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [about-home]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Trying to split up the reviews burden, mconnor suggested this and I think he can review (And eveventually approve?) it :) Asking approval at the same time since the patch is trivial.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #510596 -
Flags: review?(mconnor)
Attachment #510596 -
Flags: approval2.0?
|
||
Comment 4•13 years ago
|
||
Comment on attachment 510596 [details] [diff] [review] patch v1.0 I am not a current browser peer, but I can approve it once I see a review!
Attachment #510596 -
Flags: review?(mconnor) → review?(dolske)
|
||
Updated•13 years ago
|
Attachment #510596 -
Flags: review?(dolske)
Attachment #510596 -
Flags: review+
Attachment #510596 -
Flags: approval2.0?
Attachment #510596 -
Flags: approval2.0+
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4215b25a76c2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•