631170 - mouse hover broken in Qt build

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Florian Hänel [:heeen]]

onmouseover does not work in qt build, for example:
http://de.selfhtml.org/javascript/sprache/anzeige/onmouseover.htm

Also the mouse cursor does not change from content or gets stuck with one cursor shape for the whole window
http://de.selfhtml.org/css/eigenschaften/anzeige/cursor.htm

Comment 1

[Florian Hänel [:heeen]]

Attachment: fixes hover events

This fixes hover events for both chrome and content. Tested with urls above and hovering over menubar also switches between menu popups.

Comment 2

[Florian Hänel [:heeen]]

Attachment: fixes hover events

missed one commented out line

Comment 3

[Florian Hänel [:heeen]]

Attachment: fix selection

We have to support both MouseMove and HoverMove: the former is fired when click+drag is used, like to select text or drag bookmarks, the latter for pure hovering over things.

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 509390 [details] [diff] [review]
fix selection


>-    mReceiver->OnMotionNotifyEvent(aEvent);
>+    mReceiver->OnMouseMoveEvent(aEvent);

don't create new dup function
just make OnMotionNotifyEvent(aPos, aModifiers)

and call it for Move and Hover event.

Comment 5

[Florian Hänel [:heeen]]

Attachment: fixed nits

n/t

Comment 6

[Oleg Romashin (:romaxa)]

Comment on attachment 509402 [details] [diff] [review]
fixed nits


>+    mMoveEvent.pos=aPos;
                     ^ - spaces missing
>+    mMoveEvent.modifiers=aModifiers;
                          ^ - spaces missing

r+ with style fixed

Comment 7

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/344de3f6033f