Closed Bug 631175 Opened 13 years ago Closed 13 years ago

Javascript errors in reports don't align with Mozmill generated failures

Categories

(Testing Graveyard :: Mozmill, defect)

All
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: whimboo, Unassigned)

References

()

Details

With the fix on bug 608139 we now also report Javascript failures on chrome side. After installing Mozmill 1.5.2 rc3 on our qa-horus box, which runs the daily tests, I have noticed that the format how Javascript Errors are reported is not aligned to our general exception messages:

"[JavaScript Error: \"document is null\" {file: \"chrome://browser/content/browser.js\" line: 12728}]",

vs.

{
          "exception": {
            "message": "could not find element ID: localization",
            "lineNumber": 851,
            "stack": "[...]",
            "fileName": "resource://mozmill/modules/controller.js"
          }
}

It's really important to have the same format. Otherwise it's more than painful for us to parse those reports. An example report can be found in the URL.
> "[JavaScript Error: \"document is null\" {file:
> \"chrome://browser/content/browser.js\" line: 12728}]"

That looks like an error that was retrieved from the error console.  We removed the console listener completely, so I'm not quite sure how you're seeing that error.  Are you sure you don't have some branch off of hotfix-1.5.2 checked out?

Otherwise what did you do to reproduce this error?
This happened with Mozmill 1.5.2 RC3 installed on QA-Horus. I can try it again.
> http://mozmill-archive.brasstacks.mozilla.com/#/general/report/00edfccff35537bd5dcddb5129905a1b

Sorry, I think I'm just not understanding something.  I don't see "[JavaScript Error..." anywhere in that report?
Seems to be a Linux only issue. I don't see this failure on other platforms.
OS: All → Linux
(In reply to comment #4)
> > http://mozmill-archive.brasstacks.mozilla.com/#/general/report/00edfccff35537bd5dcddb5129905a1b
> 
> Sorry, I think I'm just not understanding something.  I don't see "[JavaScript
> Error..." anywhere in that report?

That's what I said. The format of the error message is unknown, that's why it is not shown. See the failures without the information. Take the URL from the URL field and format the json i.e. with http://jsonviewer.stack.hu/ to see those lines.
I ran 1.5.2rc3 with 4b10 and the latest nightly on Ubuntu 10.10 (local box). As generated, my report is indicating zero issue:

http://mozmill-archive.brasstacks.mozilla.com/#/general/report/00edfccff35537bd5dcddb512995f7ac
(In reply to comment #7)
> I ran 1.5.2rc3 with 4b10 and the latest nightly on Ubuntu 10.10 (local box). As
> generated, my report is indicating zero issue:
> 
> http://mozmill-archive.brasstacks.mozilla.com/#/general/report/00edfccff35537bd5dcddb512995f7ac

This is a 64bit version and not a 32bit one. Could that make a difference?
qa-horus is running with 10.4 at the moment. Even it shouldn't make a difference I'm updating this bug at the moment.
Those failures on qa-horus were caused by the lingering Python environment from Anthony. While the mozmill binary was still run from /usr/local/bin the Python module has been imported from /data/testing/ashughes/mozmill-1.5.2dev-env.

That's also the reason for all the failures we have seen on that machine in the last couple of days or even weeks. I have cleaned everything up now and we should hopefully be ok again. Lets wait for the results.
Ok, it's fixed now:

http://mozmill-archive.brasstacks.mozilla.com/#/general/report/00edfccff35537bd5dcddb5129b4d4d3

Marking as invalid due to a bad python module reference.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Whiteboard: [mozmill-1.5.2?]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.