631189 - About Mozilla overlaps on to the other elements in the home page

Status: RESOLVED FIXED

Description

[Srinivas]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110202 Firefox/4.0b12pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110202 Firefox/4.0b12pre

About Mozilla overlaps on to the other elements in the home page while resizing the Fx window

Reproducible: Always

Steps to Reproduce:
1.Open Fx and navigate to about:home
2.Resize the firefox window to 340*315 pixel size
3.Observe the link About Mozilla and the botton
Actual Results:  
Link "About Mozilla" overlaps on the button and the button overlaps on the "Preferences" making it unable to click

Comment 1

[Srinivas]

Created attachment 509379 [details]
Screenshot

Comment 2

[Teodosia Pop]

Able to reproduce on Win 7 and Mac 10.6 using 
Mozilla/5.0 (Windows NT 6.1; rv:2.0b11) Gecko/20100101 Firefox/4.0b11 
and
Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110203 Firefox/4.0b12pre 

Setting the resolution to NEW.

Comment 3

[Teodosia Pop]

Regression window:
Last good build: http://hg.mozilla.org/mozilla-central/rev/94a51a3b64d4 

First bad build: http://hg.mozilla.org/mozilla-central/rev/336d5906cb0f

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=94a51a3b64d4 &tochange=336d5906cb0f

Comment 4

[Marco Bonardo [::mak]]

I guess we could want a min-height on the page.

Comment 5

[Jez Ng [:int3]]

Created attachment 549637 [details] [diff] [review]
Patch v1

This hides the 'About Mozilla' link when the screen gets too small. I also tweaked things such that the 'About Mozilla' link doesn't overlap the 'Restore Previous Session' button for a ~470px window.

Comment 6

[Marco Bonardo [::mak]]

Comment on attachment 549637 [details] [diff] [review]
Patch v1

Review of attachment 549637 [details] [diff] [review]:
-----------------------------------------------------------------

the patch looks good, but trying to resize the page, the jump due to the searchbox height change becomes too much visible.
Thus I suggest that in addition to this we also replace:

@media all and (max-height: 450px) {
  #searchContainer { height: 30% }
}

with:

@media all and (max-height: 500px) {
  #searchContainer { height: 25% }
}

@media all and (max-height: 370px) {
  #searchContainer { height: 30% }
}

for a smoother balancing on resize (and to balance your top change at 500px)

Comment 8

[Jez Ng [:int3]]

Created attachment 550269 [details] [diff] [review]
Patch v2

Updated patch with suggestion.

I noticed the jumpiness too while testing; I'm not sure this change reduces it by much, but it does make things look more balanced.

Comment 9

[Ed Morley [:emorley]]

In my queue, pushing to inbound once confirmed everything builds locally.

Comment 10

[Ed Morley [:emorley]]

s/everything/everything else/

Also, for future patches, can you check your hgrc is set up like here:
blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
...since the current patch was missing the |# HG changeset patch| line, which causes hg qimport to break and put the author in the commit field etc.

Thanks :-)

Comment 11

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c76345028fa7

Comment 12

[Marco Bonardo [::mak]]

http://hg.mozilla.org/mozilla-central/rev/c76345028fa7