Closed Bug 631192 Opened 9 years ago Closed 9 years ago

Overlay with status messages is misaligned with aero glass in non-maximized windows

Categories

(Firefox :: Theme, defect, trivial)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 4.0b12

People

(Reporter: Terepin, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(2 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre

See screenshot.

Reproducible: Always
Attached image Screenshot
Blocks: 628654
Keywords: polish
Component: General → Theme
QA Contact: general → theme
Summary: Overlay with status messages is misaligned → Overlay with status messages is misaligned with aero glass in non-maximized windows
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → dao
Attached patch patch (obsolete) — Splinter Review
Attachment #510261 - Flags: review?(gavin.sharp)
Attachment #510261 - Flags: review?(felipc)
What other style rules makes this necessary? I don't really understand what the comment refers to.
Attachment #510261 - Flags: review?(gavin.sharp)
Attachment #510261 - Flags: review+
Attachment #510261 - Flags: approval2.0+
Won't this override http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#2272 ?

Most of the CSS uses quotes for the attribute matching, but I see some more recent code without them. Is this a trend?
(In reply to comment #5)
> Won't this override
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser.css#2272
> ?

I don't think so, but will double-check.

> Most of the CSS uses quotes for the attribute matching, but I see some more
> recent code without them. Is this a trend?

Yes! :)
Attached patch patch v2 (obsolete) — Splinter Review
Felipe was right, the previous patch was overriding the status panel's horizontal margin towards the center of the content area (which, when hovered, causes the panel to move to the other side). I was expecting the opposite (i.e. that the existing margin would override the 1px margin when needed).

.statuspanel-inner never has a padding, so there's no such interference.
Attachment #510261 - Attachment is obsolete: true
Attachment #510410 - Flags: review?(gavin.sharp)
Attachment #510261 - Flags: review?(felipc)
Comment on attachment 510410 [details] [diff] [review]
patch v2

Should you use the same :not(inFullscreen) selector as the border style, to avoid the same flicker?
Attached patch patch v3 (obsolete) — Splinter Review
Can't hurt to add it. If you go fullscreen while a page is loading and focus on the status panel, I think you can see it move by one pixel.
Attachment #510416 - Flags: review?(gavin.sharp)
Comment on attachment 510416 [details] [diff] [review]
patch v3

one of those "left"s wants to be a "right"
Attachment #510416 - Flags: review?(gavin.sharp)
Attachment #510416 - Flags: review+
Attachment #510416 - Flags: approval2.0+
Attachment #510410 - Attachment is obsolete: true
Attachment #510410 - Flags: review?(gavin.sharp)
Duplicate of this bug: 632032
Attached patch for check-inSplinter Review
Attachment #510416 - Attachment is obsolete: true
Keywords: checkin-needed
Duplicate of this bug: 632249
http://hg.mozilla.org/mozilla-central/rev/dd1474517009
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre

Verified issue and it's no longer present.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.