Cannot Setup Sync error appears when browsing

VERIFIED FIXED

Status

VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: ioana.chiorean, Assigned: wesj)

Tracking

Trunk
ARM
Android

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 509394 [details]
screenshot

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:2.0b12pre)
Gecko/20110202 Firefox/4.0b12pre Fennec/4.0b5pre 
Device HTC Desire A8181
OS: Android 2.1

Steps to reproduce:
1. Start Fennec
2. Go to about:firstrun
3. Press Sync Up
4. At the pop up with Connect to Sync, Press Cancel or System's Back button
5. Browse anything you want  for few minutes.

Expected result:
- the browsing should occur without any problems

Actual result:
- A Cannot Setup Sync error appears

Note:
- please take a look at the attached photo.
Wes - sounds like an edge case where we need to check to see if the dialog is even open. we should be aborting the jpake if we close the dialog, but I guess we aren't _or_ it's still calling our error callback and we need to not show the error if we are not showing the dialog anymore.
Assignee: nobody → wjohnston
tracking-fennec: --- → 2.0+
(Assignee)

Comment 2

8 years ago
Created attachment 510390 [details] [diff] [review]
Patch v1

Not really sure how this could happen unless we've somehow closed the dialog without calling abortEasySetup(). Only case I can think of is if the user hits the back button/esc to get out of the dialog rather than hitting cancel?

This forces us to cancel jpake when we close the dialog.
Attachment #510390 - Flags: review?(mark.finkle)
Attachment #510390 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

8 years ago
pushed:
http://hg.mozilla.org/mobile-browser/rev/96d587378dbf
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 4

8 years ago
Verified on:

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20100307
Firefox/4.0b13pre Fennec/4.0b6pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.