Closed Bug 631252 Opened 9 years ago Closed 9 years ago

Use -mstackrealign on 32-bit mingw

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
I've hit another problem similar to bug 627341. After more investigations and consultations, I know that the right solution is to use -mstackrealign for GCC 32-bit Windows target (it should probably be even default in GCC). The attached patch adds -mstackrealign to CFLAGS and CXXFLAGS in configure script (and reverts the fix from bug 627341 as it's no longer needed).
Attachment #509439 - Flags: review?(dbaron)
Comment on attachment 509439 [details] [diff] [review]
fix v1.0

r=dbaron
Attachment #509439 - Flags: review?(dbaron) → review+
http://hg.mozilla.org/mozilla-central/rev/fa442c0d6d29
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 803856
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.