Last Comment Bug 631269 - Reduce duplicate code in CloneAndReplaceChild
: Reduce duplicate code in CloneAndReplaceChild
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: mozilla7
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2011-02-03 09:42 PST by Dave Townsend [:mossop]
Modified: 2011-05-28 04:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (3.20 KB, patch)
2011-05-27 03:31 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description Dave Townsend [:mossop] 2011-02-03 09:42:26 PST
Bug 602256 made both paths there do the same thing in some cases so it is probably possible to reduce the duplicate code there, or just replace the whole function with a simpler function.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-02-03 09:54:50 PST
Dave, you want to take this, or should I?
Comment 2 Dave Townsend [:mossop] 2011-02-03 10:59:25 PST
I probably wouldn't get around to it for a while
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-05-27 03:31:05 PDT
Created attachment 535599 [details] [diff] [review]
Patch v1

Something like this, perhaps?
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2011-05-27 11:39:14 PDT
Comment on attachment 535599 [details] [diff] [review]
Patch v1

Yep, like that.
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2011-05-28 04:02:13 PDT

Note You need to log in before you can comment on or make changes to this bug.