Reduce duplicate code in CloneAndReplaceChild

RESOLVED FIXED in mozilla7

Status

()

Core
Document Navigation
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mossop, Assigned: Ms2ger)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 602256 made both paths there do the same thing in some cases so it is probably possible to reduce the duplicate code there, or just replace the whole function with a simpler function.
Dave, you want to take this, or should I?
(Reporter)

Comment 2

6 years ago
I probably wouldn't get around to it for a while
Assignee: nobody → bzbarsky
Priority: -- → P2
(Assignee)

Comment 3

6 years ago
Created attachment 535599 [details] [diff] [review]
Patch v1

Something like this, perhaps?
Assignee: bzbarsky → Ms2ger
Status: NEW → ASSIGNED
Attachment #535599 - Flags: review?(bzbarsky)
Comment on attachment 535599 [details] [diff] [review]
Patch v1

Yep, like that.
Attachment #535599 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/b7d2e7c6f663
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.