Closed Bug 631269 Opened 13 years ago Closed 12 years ago

Reduce duplicate code in CloneAndReplaceChild

Categories

(Core :: DOM: Navigation, defect, P2)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: mossop, Assigned: Ms2ger)

Details

Attachments

(1 file)

Patch v1
3.20 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
Bug 602256 made both paths there do the same thing in some cases so it is probably possible to reduce the duplicate code there, or just replace the whole function with a simpler function.
Dave, you want to take this, or should I?
I probably wouldn't get around to it for a while
Assignee: nobody → bzbarsky
Priority: -- → P2
Attached patch Patch v1 — — Splinter Review 
Something like this, perhaps?
Assignee: bzbarsky → Ms2ger
Status: NEW → ASSIGNED
Attachment #535599 - Flags: review?(bzbarsky)
Comment on attachment 535599 [details] [diff] [review]
Patch v1

Yep, like that.
Attachment #535599 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/b7d2e7c6f663
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.