Last Comment Bug 631269 - Reduce duplicate code in CloneAndReplaceChild
: Reduce duplicate code in CloneAndReplaceChild
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: mozilla7
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-03 09:42 PST by Dave Townsend [:mossop]
Modified: 2011-05-28 04:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (3.20 KB, patch)
2011-05-27 03:31 PDT, :Ms2ger
bzbarsky: review+
Details | Diff | Review

Description Dave Townsend [:mossop] 2011-02-03 09:42:26 PST
Bug 602256 made both paths there do the same thing in some cases so it is probably possible to reduce the duplicate code there, or just replace the whole function with a simpler function.
Comment 1 Boris Zbarsky [:bz] 2011-02-03 09:54:50 PST
Dave, you want to take this, or should I?
Comment 2 Dave Townsend [:mossop] 2011-02-03 10:59:25 PST
I probably wouldn't get around to it for a while
Comment 3 :Ms2ger 2011-05-27 03:31:05 PDT
Created attachment 535599 [details] [diff] [review]
Patch v1

Something like this, perhaps?
Comment 4 Boris Zbarsky [:bz] 2011-05-27 11:39:14 PDT
Comment on attachment 535599 [details] [diff] [review]
Patch v1

Yep, like that.

Note You need to log in before you can comment on or make changes to this bug.