Closed Bug 631298 Opened 9 years ago Closed 9 years ago

Status/link bubble doesn't shrink to fit contents when it's too large from previous text

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 4.0b12

People

(Reporter: davemgarrett, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

STR:
0) latest build with bug 541656 (using Tinderbox build; not in nightlies yet)
1) bookmark the following URL into the bookmarks menu:
http://www.google.com/search?q=thisisalongurltestaaaaaaaaaaaaaaaaaaaaaaaaaaaaa12345&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:unofficial&client=firefox-a
2) maximize Firefox (just makes this bug more noticeable)
3) open the bookmarks menu and hover over the bookmark
4) a popup half of the browser's width containing a truncated version of that URL will show in the lower left corner of the browser
5) click the bookmark
6) the status text for loading the URL will appear in that bubble

Actual results:
The bubble stays the same long size with lots of empty space to the right of the status text until the bubble closes.

Expected results:
If you simply visit the URL normally the status bubble is much smaller with less wasted space. It should resize to fit the content as needed to avoid dead space covering up more of the page.
This was done intentionally in bug 629898.
(In reply to comment #1)
> This was done intentionally in bug 629898.

Per bug 629898 comment 2 you stated that the intent was to set a "25% min-width and lets the statuspanel grow but not shrink for value changes, until the value gets reset". Personally, I liked it always autosizing; it looked cleaner. In any case, with this particular bug I'm specifically talking about a large size drop, so it seems that the value just needs to be reset on transition from link URL to status text because of the potential large change in size.
Blocks: 629898
Legend:
|statuspanel|
* -link 
... -nothing

Now it is:
|**...| 25%
|******|
|*******|
|********|
|**********|50%
|********..|
|******....|
|*****.....|
|**........|50% - here it could be 25%
Without patch in bug 629898 statuspanel width was 0-50%.
With patch it stays at 50%.
Maybe it could shrink to 25%, but not less because of intention in bug 629898.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #509704 - Flags: review?(gavin.sharp)
updated to tip
Attachment #509704 - Attachment is obsolete: true
Attachment #510116 - Flags: review?(gavin.sharp)
Attachment #509704 - Flags: review?(gavin.sharp)
Blocks: 631992
Attachment #510116 - Flags: review?(gavin.sharp)
Attachment #510116 - Flags: review+
Attachment #510116 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/5c3e3621f86e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Verified using Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.