631339 - White flash when new windows (awesomebar, form complete, about window, etc) open

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Due to the workaround for bug 603134, we can get a single white flash on new windows - the content draws, is cleared, and then draws again.

It might not be possible to work around this while keeping the workaround for bug 603134 working, though, so once Apple fixes the underlying Mac bug, we should remove the workaround.

Comment 1

[Markus Stange [:mstange]]

Whoa, that's some intense flashing. Luckily it only seems to affect popup windows, and only happens when they open the first time.
Bug 562138 would probably fix this, but I won't get to debugging all the regressions that caused in time for Firefox 4...
Maybe we should turn off acceleration for popup windows altogether?

Comment 2

[Joe Drew (not getting mail)]

This is bad enough that I think it should block. And yeah, we should probably only accelerate full-screen windows and main Firefox windows; everything else (including the About window) can be software-only.

Markus, can you look into this? If not, reassign to me - I'll be on vacation next week, though.

Comment 3

[Joe Drew (not getting mail)]

(Ideally we'd be able to maintain hardware acceleration on these windows, but I don't know if it's possible to stop the window from updating when we dissociate the view from the GL context.)

Comment 4

[Markus Stange [:mstange]]

Attachment: don't accelerate popup windows

Comment 5

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/5cdf898ba382